Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): i18n - ignore alt-trans tags in XLIFF 1.2 #33464

Closed
wants to merge 1 commit into from
Closed

fix(compiler): i18n - ignore alt-trans tags in XLIFF 1.2 #33464

wants to merge 1 commit into from

Conversation

petebacondarwin
Copy link
Member

This is a patch version of #33450.

@petebacondarwin
fix(compiler): i18n - ignore alt-trans tags in XLIFF 1.2
aa33863 
The parser was accidentally reading the `target` tag
below the `alt-trans` target and overriding the correct
`target` tag.

Fixes angular#33161
@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n PR target: patch-only area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 29, 2019
@petebacondarwin petebacondarwin requested review from a team as code owners October 29, 2019 11:34
@ngbot ngbot bot modified the milestone: needsTriage Oct 29, 2019
@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 29, 2019
@AndrewKushnir AndrewKushnir added the action: presubmit The PR is in need of a google3 presubmit label Oct 29, 2019
@AndrewKushnir
Copy link
Contributor

Presubmit for these changes is a part of the master-only version of this PR (#33450).

@AndrewKushnir AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Oct 29, 2019
AndrewKushnir pushed a commit that referenced this pull request Oct 29, 2019
@petebacondarwin @AndrewKushnir
fix(compiler): i18n - ignore alt-trans tags in XLIFF 1.2 (#33464)
f97c464 
The parser was accidentally reading the `target` tag
below the `alt-trans` target and overriding the correct
`target` tag.

Fixes #33161

PR Close #33464
@AndrewKushnir
Copy link
Contributor

This PR is now merged into patch branch. Thank you.

@petebacondarwin petebacondarwin deleted the i18n-alt-trans-patch branch October 30, 2019 21:24
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler area: i18n cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@petebacondarwin @AndrewKushnir @googlebot