Fw 1559 - more cases

[pkozlowski-opensource]

This is a version of #33457 that has more tests and handles more cases.

[pkozlowski-opensource]

core/todo/bundle increased by 126 bytes.

This is mostly due to the fact that we are starting to have code duplication with

angular/packages/core/src/render3/node_manipulation.ts

Lines 75 to 116 in 5666d11

	function applyToElementOrContainer(
	action: WalkTNodeTreeAction, renderer: Renderer3, parent: RElement | null,
	lNodeToHandle: RNode | LContainer | LView, beforeNode?: RNode | null) {
	// If this slot was allocated for a text node dynamically created by i18n, the text node itself
	// won't be created until i18nApply() in the update block, so this node should be skipped.
	// For more info, see "ICU expressions should work inside an ngTemplateOutlet inside an ngFor"
	// in `i18n_spec.ts`.
	if (lNodeToHandle != null) {
	let lContainer: LContainer|undefined;
	let isComponent = false;
	// We are expecting an RNode, but in the case of a component or LContainer the `RNode` is
	// wrapped in an array which needs to be unwrapped. We need to know if it is a component and if
	// it has LContainer so that we can process all of those cases appropriately.
	if (isLContainer(lNodeToHandle)) {
	lContainer = lNodeToHandle;
	} else if (isLView(lNodeToHandle)) {
	isComponent = true;
	ngDevMode && assertDefined(lNodeToHandle[HOST], 'HOST must be defined for a component LView');
	lNodeToHandle = lNodeToHandle[HOST] !;
	}
	const rNode: RNode = unwrapRNode(lNodeToHandle);
	ngDevMode && !isProceduralRenderer(renderer) && assertDomNode(rNode);
	if (action === WalkTNodeTreeAction.Create && parent !== null) {
	if (beforeNode == null) {
	nativeAppendChild(renderer, parent, rNode);
	} else {
	nativeInsertBefore(renderer, parent, rNode, beforeNode || null);
	}
	} else if (action === WalkTNodeTreeAction.Insert && parent !== null) {
	nativeInsertBefore(renderer, parent, rNode, beforeNode || null);
	} else if (action === WalkTNodeTreeAction.Detach) {
	nativeRemoveNode(renderer, rNode, isComponent);
	} else if (action === WalkTNodeTreeAction.Destroy) {
	ngDevMode && ngDevMode.rendererDestroyNode++;
	(renderer as ProceduralRenderer3).destroyNode !(rNode);
	}
	if (lContainer != null) {
	applyContainer(renderer, action, lContainer, parent, beforeNode);
	}
	}
	}

In the essence both code-paths are solving the same problem - give me a set of root native nodes. We just happen to do it for different purposes, but the returned value is the same.

We need to remove this code duplication in a follow-up PR(s)

[pkozlowski-opensource]

@AndrewKushnir it seems like VE and ivy are generating very different DOM when it comes to ICU expressions. Not sure if this is intended and if not, are we tracking it anywhere?

[mhevery]

This would be expected for ICU expressions.

[mhevery]

presubmit
ivy presubmit

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}