Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template perf #33511

Conversation

pkozlowski-opensource
Copy link
Member

This PR includes a new benchmark focused on <ng-template> processing in the creation mode + a trivial improvement that speeds up this benchmark by ~15%by avoiding lookup-up in data structures when we've got data ready

@pkozlowski-opensource pkozlowski-opensource added comp: ivy action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Oct 31, 2019
@ngbot ngbot bot modified the milestone: needsTriage Oct 31, 2019
@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review October 31, 2019 15:56
@pkozlowski-opensource pkozlowski-opensource requested a review from a team as a code owner October 31, 2019 15:56
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 31, 2019
@mhevery
Copy link
Contributor

mhevery commented Oct 31, 2019

presubmit
ivy presubmit

@AndrewKushnir AndrewKushnir added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Oct 31, 2019
atscott pushed a commit that referenced this pull request Oct 31, 2019
@atscott atscott closed this in df1bef3 Oct 31, 2019
atscott pushed a commit that referenced this pull request Oct 31, 2019
mohaxspb pushed a commit to mohaxspb/angular that referenced this pull request Nov 7, 2019
mohaxspb pushed a commit to mohaxspb/angular that referenced this pull request Nov 7, 2019
mohaxspb pushed a commit to mohaxspb/angular that referenced this pull request Nov 7, 2019
mohaxspb pushed a commit to mohaxspb/angular that referenced this pull request Nov 7, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants