fix(ivy): avoid implicit any errors in event handlers #33550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
added
type: bug/fix
action: review
When template type checking is configured with `strictDomEventTypes` or `strictOutputEventTypes` disabled, in compilation units that have `noImplicitAny` enabled but `strictNullChecks` disabled, a template type checking error could be produced for certain event handlers. The error is avoided by letting an event handler in the generated TCB always have an explicit `any` return type. Fixes angular#33528
JoostK
force-pushed
the
ngtsc-ttc-implicit-any
branch
from
657831b
to
ac4c935
Compare
|
Presubmit |
alxhub
added
action: merge
alxhub
approved these changes
Nov 6, 2019
atscott
pushed a commit
that referenced
this pull request
Nov 6, 2019
When template type checking is configured with `strictDomEventTypes` or `strictOutputEventTypes` disabled, in compilation units that have `noImplicitAny` enabled but `strictNullChecks` disabled, a template type checking error could be produced for certain event handlers. The error is avoided by letting an event handler in the generated TCB always have an explicit `any` return type. Fixes #33528 PR Close #33550
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
When template type checking is configured with `strictDomEventTypes` or `strictOutputEventTypes` disabled, in compilation units that have `noImplicitAny` enabled but `strictNullChecks` disabled, a template type checking error could be produced for certain event handlers. The error is avoided by letting an event handler in the generated TCB always have an explicit `any` return type. Fixes angular#33528 PR Close angular#33550
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
When template type checking is configured with `strictDomEventTypes` or `strictOutputEventTypes` disabled, in compilation units that have `noImplicitAny` enabled but `strictNullChecks` disabled, a template type checking error could be produced for certain event handlers. The error is avoided by letting an event handler in the generated TCB always have an explicit `any` return type. Fixes angular#33528 PR Close angular#33550
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When template type checking is configured with
strictDomEventTypesorstrictOutputEventTypesdisabled, in compilation units that havenoImplicitAnyenabled butstrictNullChecksdisabled, a template typechecking error could be produced for certain event handlers.
The error is avoided by letting an event handler in the generated TCB
always have an explicit
anyreturn type.Fixes #33528