fix(core): undecorated-classes-with-di migration should report config errors #33567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… errors Currently TypeScript projects with an invalid tsconfig configuration, cause the undecorated-classes-with-di migration to throw. Instead we should gracefully exit the migration (like we do for syntactical diagnostics), but report that there are configuration issues. This issue surfaced when testing this migration in combination with the Angular CLI migrations. One of the CLI migrations currently causes invalid tsconfig files which then cause this issue in the undecorated-classes-with-di migration.
devversion
added
area: core
kara
added
action: presubmit
atscott
pushed a commit
that referenced
this pull request
Nov 5, 2019
… errors (#33567) Currently TypeScript projects with an invalid tsconfig configuration, cause the undecorated-classes-with-di migration to throw. Instead we should gracefully exit the migration (like we do for syntactical diagnostics), but report that there are configuration issues. This issue surfaced when testing this migration in combination with the Angular CLI migrations. One of the CLI migrations currently causes invalid tsconfig files which then cause this issue in the undecorated-classes-with-di migration. PR Close #33567
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
… errors (angular#33567) Currently TypeScript projects with an invalid tsconfig configuration, cause the undecorated-classes-with-di migration to throw. Instead we should gracefully exit the migration (like we do for syntactical diagnostics), but report that there are configuration issues. This issue surfaced when testing this migration in combination with the Angular CLI migrations. One of the CLI migrations currently causes invalid tsconfig files which then cause this issue in the undecorated-classes-with-di migration. PR Close angular#33567
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
… errors (angular#33567) Currently TypeScript projects with an invalid tsconfig configuration, cause the undecorated-classes-with-di migration to throw. Instead we should gracefully exit the migration (like we do for syntactical diagnostics), but report that there are configuration issues. This issue surfaced when testing this migration in combination with the Angular CLI migrations. One of the CLI migrations currently causes invalid tsconfig files which then cause this issue in the undecorated-classes-with-di migration. PR Close angular#33567
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently TypeScript projects with an invalid tsconfig configuration,
cause the undecorated-classes-with-di migration to throw. Instead we
should gracefully exit the migration (like we do for syntactical
diagnostics), but report that there are configuration issues.
This issue surfaced when testing this migration in combination
with the Angular CLI migrations. One of the CLI migrations currently
causes invalid tsconfig files which then cause this issue in the
undecorated-classes-with-di migration. angular/angular-cli#16035