New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
NGCC fails with array spread in module declarations #33614
Milestone
Comments
//cc @petebacondarwin & @CaerusKaru |
alan-agius4
added a commit
to alan-agius4/flex-layout
that referenced
this issue
Nov 6, 2019
This is causing the consumption of the library to fail. See: angular/angular#33614
14 tasks
atscott
pushed a commit
that referenced
this issue
Nov 6, 2019
We already have special cases for the `__spread` helper function and with this change we handle the new tslib helper introduced in version 1.10 `__spreadArrays`. For more context see: https://github.com/microsoft/tslib/releases/tag/1.10.0 Fixes: #33614 PR Close #33617
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this issue
Nov 7, 2019
We already have special cases for the `__spread` helper function and with this change we handle the new tslib helper introduced in version 1.10 `__spreadArrays`. For more context see: https://github.com/microsoft/tslib/releases/tag/1.10.0 Fixes: angular#33614 PR Close angular#33617
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this issue
Nov 7, 2019
We already have special cases for the `__spread` helper function and with this change we handle the new tslib helper introduced in version 1.10 `__spreadArrays`. For more context see: https://github.com/microsoft/tslib/releases/tag/1.10.0 Fixes: angular#33614 PR Close angular#33617
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
馃悶 bug report
Affected Package
@angular/compiler-cli
Is this a regression?
Yes, used to work with VE.
Description
When a module declaration contains an array spread example:
When compiled down to ES5 TypeScript will add tslib helpers in this case the
__spreadArrays
.When NGCC is run on this code it will error out that it expected an array in
declarations
. previously this used to be allowed in VE.馃敟 Exception or Error
馃實 Your Environment
Angular Version: 9.0.0-rc.0
Related to angular/flex-layout#1143
The text was updated successfully, but these errors were encountered: