-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): remove deprecated and defunct wtf* apis #33949
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@IgorMinar , should we also remove |
These apis have been deprecated in v8, so they should stick around till v10, but since they are defunct we are removing them early so that they don't take up payload size.
a266d47
to
b6b42b2
Compare
You can preview b6b42b2 at https://pr33949-b6b42b2.ngbuilds.io/. |
hmm @JiaLiPassion I didn't realize that there was a wtf specific zone spec. Is anyone using it? this zone spec is separate from exposing the wtf apis so I think it's ok to remove stuff from core, but keep wtf support in zone.js. |
thanks for pointing this out btw |
I'm marking this as blocked until we agree on the zone.js spec story |
You can preview 937d528 at https://pr33949-937d528.ngbuilds.io/. |
looking into this more, I think we should go ahead with this change as is without removing the zone.js integration in ng_zone. That can be done separately in the future. |
merge-assistance: global approval |
@IgorMinar , yeah, sure, there is no harm to leave the |
These apis have been deprecated in v8, so they should stick around till v10, but since they are defunct we are removing them early so that they don't take up payload size. PR Close #33949
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
These apis have been deprecated in v8, but since they are defunct we are removing them early so that they don't take up payload size.
Closes #12509