-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): support Attribute
DI decorator in deps
section of a token
#37085
fix(core): support Attribute
DI decorator in deps
section of a token
#37085
Conversation
7ae08ef
to
03cfa98
Compare
0489f41
to
014b123
Compare
Attribute
DI decorator in deps
section o…Attribute
DI decorator in deps
section of a token
3d635a8
to
ef89ae4
Compare
You can preview 7e37bd8 at https://pr37085-7e37bd8.ngbuilds.io/. |
60c5fe8
to
06303e9
Compare
You can preview 06303e9 at https://pr37085-06303e9.ngbuilds.io/. |
06303e9
to
e67a164
Compare
You can preview e67a164 at https://pr37085-e67a164.ngbuilds.io/. |
e67a164
to
0adbfe3
Compare
You can preview 0adbfe3 at https://pr37085-0adbfe3.ngbuilds.io/. |
@AndrewKushnir How did the presubmit go? |
This commit moves the `injectAttributeImpl` and other dependent code to avoid circular dependencies.
Sweet. Thanks @mhevery |
dfc8c2c
to
6ac2d2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: global-approvers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FYI, I'm adding the "cleanup" labels since the CI is failing and the g3 check is not "green". Thank you. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
This commit moves the `injectAttributeImpl` and other dependent code to avoid circular dependencies. PR Close #37085
This commit moves the `injectAttributeImpl` and other dependent code to avoid circular dependencies. PR Close #37085
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: Fixes #36479
What is the new behavior?
Does this PR introduce a breaking change?