fix(compiler): check more cases for pipe usage inside host bindings #37883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
area: compiler
JoostK
requested changes
Jul 2, 2020
Builds on top of angular#34655 to support more cases that could be using a pipe inside host bindings (e.g. ternary expressions or function calls). Fixes angular#37610.
crisbeto
force-pushed
the
FW-2270/host-binding-pipe-errors
branch
from
b7a5b7d
to
2e04428
Compare
|
Thanks for the feedback @JoostK, the recursive visitor definitely cleaned things up 👍. Can you take another look? |
crisbeto
added
action: presubmit
atscott
pushed a commit
that referenced
this pull request
Jul 10, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…ngular#37883) Builds on top of angular#34655 to support more cases that could be using a pipe inside host bindings (e.g. ternary expressions or function calls). Fixes angular#37610. PR Close angular#37883
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #34655 to support more cases that could be using a pipe inside host bindings (e.g. ternary expressions or function calls).
Fixes #37610.