Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n tool should output the line containing the error #38377

Closed
3 tasks done
pburkindine opened this issue Aug 7, 2020 · 1 comment
Closed
3 tasks done

i18n tool should output the line containing the error #38377

pburkindine opened this issue Aug 7, 2020 · 1 comment

Comments

@pburkindine
Copy link

🐞 Bug report

  • xi18n
  • serve
  • build

Is this a regression?

No

Description

We receive translated messages.xlf files back from Smartling which sometimes contain mangled ICUs (missing or added closing brackets, mostly). We have thousands of trans-units, and the angular CLI just outputs "Error: Invalid ICU message. Missing '}'." This is true for serve as well as build

Without a reference to the trans-unit or the line in the ICU containing the error, this is a needle in a haystack. Finding it involves combing through the diff one change at a time looking for the ICU that's broken.

🔥 Exception or Error

"Error: Invalid ICU message. Missing '}'."

🌍 Your Environment


╰─ npx ng version                                                                                             2849  10:35:05   

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 10.0.4
Node: 12.16.3
OS: darwin x64

Angular: 10.0.7
... animations, common, compiler, compiler-cli, core, forms
... language-service, localize, platform-browser
... platform-browser-dynamic, router, service-worker
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.1000.5
@angular-devkit/build-angular     0.1000.4
@angular-devkit/build-optimizer   0.1000.4
@angular-devkit/build-webpack     0.1000.4
@angular-devkit/core              10.0.4
@angular-devkit/schematics        10.0.4
@angular/cdk                      9.2.4
@angular/cli                      10.0.4
@angular/material                 9.2.4
@ngtools/webpack                  10.0.4
@schematics/angular               10.0.4
@schematics/update                0.1000.4
rxjs                              6.5.5
typescript                        3.9.7
webpack                           4.43.0
@alan-agius4 alan-agius4 transferred this issue from angular/angular-cli Aug 7, 2020
@ngbot ngbot bot added this to the needsTriage milestone Aug 7, 2020
@petebacondarwin petebacondarwin added area: compiler Issues related to `ngc`, Angular's template compiler feature Issue that requests a new feature labels Aug 12, 2020
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Aug 12, 2020
@petebacondarwin petebacondarwin added type: bug/fix and removed feature Issue that requests a new feature labels Sep 2, 2020
@ngbot ngbot bot modified the milestones: Backlog, needsTriage Sep 2, 2020
@petebacondarwin petebacondarwin added state: confirmed and removed area: compiler Issues related to `ngc`, Angular's template compiler labels Sep 2, 2020
petebacondarwin added a commit to petebacondarwin/angular that referenced this issue Sep 2, 2020
Previously the position of the error in a translation file when parsing
it was not displayed. Just the error message.

Now the position (line and column) and some context is displayed
along with the error messages.

Fixes angular#38377
petebacondarwin added a commit to petebacondarwin/angular that referenced this issue Sep 2, 2020
Previously the position of the error in a translation file when parsing
it was not displayed. Just the error message.

Now the position (line and column) and some context is displayed
along with the error messages.

Fixes angular#38377
petebacondarwin added a commit to petebacondarwin/angular that referenced this issue Sep 2, 2020
Previously the position of the error in a translation file when parsing
it was not displayed. Just the error message.

Now the position (line and column) and some context is displayed
along with the error messages.

Fixes angular#38377
@atscott atscott closed this as completed in 5da1934 Sep 2, 2020
atscott pushed a commit that referenced this issue Sep 2, 2020
Previously the position of the error in a translation file when parsing
it was not displayed. Just the error message.

Now the position (line and column) and some context is displayed
along with the error messages.

Fixes #38377

PR Close #38673
profanis pushed a commit to profanis/angular that referenced this issue Sep 5, 2020
…ar#38673)

Previously the position of the error in a translation file when parsing
it was not displayed. Just the error message.

Now the position (line and column) and some context is displayed
along with the error messages.

Fixes angular#38377

PR Close angular#38673
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants