Skip to content

Cannot find module 'zone.js/dist/zone.js' after upgrade to zone.js 0.11.0 #38526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
splincode opened this issue Aug 19, 2020 · 13 comments
Closed
Labels
area: zones Issues related to zone.js state: confirmed
Milestone

Comments

@splincode
Copy link
Contributor

splincode commented Aug 19, 2020

🐞 bug report

Affected Package

The issue is caused by package zone.js

Is this a regression?

Yes

Description

thymikee/jest-preset-angular#445

FAIL  file-size.pipe.spec.ts
  ● Test suite failed to run

    Cannot find module 'zone.js/dist/zone.js' from '../../../../../node_modules/jest-preset-angular/build/setupJest.js'

    Require stack:
      /node_modules/jest-preset-angular/build/setupJest.js
      /node_modules/jest-preset-angular/index.js
      src/stubs/setupJest.ts

      at Resolver.resolveModule (../../../../../node_modules/jest-resolve/build/index.js:307:11)

🌍 Your Environment

Angular Version:


Yarn 1.26
Angular 9
Jest 26
jest-preset-angular 8

After install zone.js I am open node_modules

image

image

Where dist/zone.js?

@eran10
Copy link

eran10 commented Aug 19, 2020

same issue here

@pimmesz
Copy link

pimmesz commented Aug 19, 2020

Same here

@muuvmuuv
Copy link

Nice, no package files :D

Bildschirmfoto 2020-08-19 um 11 24 10

@ngohungphuc
Copy link

Same issue. I have to revert back to "zone.js": "~0.10.3"

@damiencal
Copy link

Same here.
How can such regressions still occur ?
For sure this one would have been caught by automated tests..

@mlc-mlapis
Copy link
Contributor

You can have hundreds of tests and you can be sure that there are always other 5 hidden mistakes, you are not aware of.

JiaLiPassion added a commit to JiaLiPassion/angular that referenced this issue Aug 19, 2020
…es field

Close angular#38526, angular#38516, angular#38513

After update to `APF`, the `directories` and `files` options are not compatible,
so we need to remove those fileds to make sure everything work as expected.
@JiaLiPassion
Copy link
Contributor

Sorry for the inconvenience, will update the npm package very soon.

@sonukapoor sonukapoor added the area: zones Issues related to zone.js label Aug 19, 2020
@ngbot ngbot bot added this to the needsTriage milestone Aug 19, 2020
@alimd
Copy link

alimd commented Aug 19, 2020

This issue proves that angular is not a enterprise ready solution!

@muuvmuuv
Copy link

It is... Idk how your production deployments look like but I can think of no developer that has NEVER break something on releases. Things happen and you can never test everything. Besides that this issue did not break any production pipeline unless you have used zone.js: "*" in your package.json and even if you should have build tests before every deployment. 🤦🏼

@mhevery
Copy link
Contributor

mhevery commented Aug 19, 2020

@crfrolik
Copy link

I am seeing a peer dependency warning when using the latest zone.js with the latest angular

warning " > @angular/core@10.0.12" has incorrect peer dependency "zone.js@~0.10.3".

subratpalhar92 pushed a commit to SUBRATPALHAR-ALL-JAVASCRIPT/angular that referenced this issue Aug 29, 2020
…es field (angular#38528)

Close angular#38526, angular#38516, angular#38513

After update to `APF`, the `directories` and `files` options are not compatible,
so we need to remove those fileds to make sure everything work as expected.

PR Close angular#38528
subratpalhar92 pushed a commit to SUBRATPALHAR-ALL-JAVASCRIPT/angular that referenced this issue Aug 31, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…es field (angular#38528)

Close angular#38526, angular#38516, angular#38513

After update to `APF`, the `directories` and `files` options are not compatible,
so we need to remove those fileds to make sure everything work as expected.

PR Close angular#38528
profanis pushed a commit to profanis/angular that referenced this issue Sep 5, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…es field (angular#38528)

Close angular#38526, angular#38516, angular#38513

After update to `APF`, the `directories` and `files` options are not compatible,
so we need to remove those fileds to make sure everything work as expected.

PR Close angular#38528
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 25, 2020
@mgechev
Copy link
Member

mgechev commented Sep 28, 2020

At Google, we have a postmortem culture, which helps us to learn from mistakes. Following this philosophy, we'd want to share what went wrong and what steps we're going to take to make sure this does not happen in the future.

You can find the postmortem document associated with this incident here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: zones Issues related to zone.js state: confirmed
Projects
None yet
Development

Successfully merging a pull request may close this issue.