fix(core): reset tView between tests in Ivy TestBed
#38659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tView` that is stored on a component def contains information about directives and pipes that are available in the scope of this component. Patching component scope causes `tView` to be updated. Prior to this commit, the `tView` information was not restored/reset in case component class is not declared in the `declarations` field while calling `TestBed.configureTestingModule`, thus causing `tView` to be reused between tests (thus preserving scopes information between tests). This commit updates TestBed logic to preserve `tView` value before applying scope changes and reset it back to the previous state between tests. Closes angular#38600.
AndrewKushnir
added
type: bug/fix
area: testing
petebacondarwin
approved these changes
Sep 1, 2020
alxhub
approved these changes
Sep 1, 2020
AndrewKushnir
added
action: merge
|
Thanks for the review @petebacondarwin and @alxhub! |
atscott
pushed a commit
that referenced
this pull request
Sep 3, 2020
`tView` that is stored on a component def contains information about directives and pipes that are available in the scope of this component. Patching component scope causes `tView` to be updated. Prior to this commit, the `tView` information was not restored/reset in case component class is not declared in the `declarations` field while calling `TestBed.configureTestingModule`, thus causing `tView` to be reused between tests (thus preserving scopes information between tests). This commit updates TestBed logic to preserve `tView` value before applying scope changes and reset it back to the previous state between tests. Closes #38600. PR Close #38659
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
`tView` that is stored on a component def contains information about directives and pipes that are available in the scope of this component. Patching component scope causes `tView` to be updated. Prior to this commit, the `tView` information was not restored/reset in case component class is not declared in the `declarations` field while calling `TestBed.configureTestingModule`, thus causing `tView` to be reused between tests (thus preserving scopes information between tests). This commit updates TestBed logic to preserve `tView` value before applying scope changes and reset it back to the previous state between tests. Closes angular#38600. PR Close angular#38659
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tViewthat is stored on a component def contains information about directives and pipes that are available in the scope of this component. Patching component scope causestViewto be updated. Prior to this commit, thetViewinformation was not restored/reset in case component class is not declared in thedeclarationsfield while callingTestBed.configureTestingModule, thus causingtViewto be reused between tests (thus preserving scopes information between tests). This commit updates TestBed logic to preservetViewvalue before applying scope changes and reset it back to the previous state between tests.Closes #38600.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?