fix(localize): do not expose NodeJS typings in $localize runtime code

[petebacondarwin]

A recent change to @angular/localize brought in the AbsoluteFsPath type
from the @angular/compiler-cli. But this brought along with it a reference
to NodeJS typings - specifically the FileSystem interface refers to the
Buffer type from NodeJS.

This affects compilation of @angular/localize code that will be run in
the browser - for example projects that reference loadTranslations().
The compilation breaks if the NodeJS typings are not included in the build.
Clearly it is not desirable to have these typings included when the project
is not targeting NodeJS.

This commit replaces references to the NodeJS Buffer type with Uint8Array,
which is available across all platforms and is actually the super-class of
Buffer.

Fixes #38692

[AndrewKushnir]

LGTM, thanks for the fix @petebacondarwin 👍

Quick question: I believe there is a chance that similar situation may happen in the future (with Buffer or other types). I was thinking if we can somehow test (as a part of a separate PR) that everything works as expected without NodeJS typings available?

[petebacondarwin]

@AndrewKushnir

I was thinking if we can somehow test (as a part of a separate PR) that everything works as expected without NodeJS typings available?

I was wondering if we could remove NodeJS typings from the file_system package altogether (i.e. via the Bazel.build file). This would be nice but of course we can't do that because of the NodeJsFileSystem which does indeed require NodeJS.

[AndrewKushnir]

Presubmit.

[AndrewKushnir]

@petebacondarwin FYI presubmit went well, plz add the "merge" label if PR is ready to go and no additional changes are needed/planned. Thank you.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}