Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(localize): render location in XLIFF 2 even if there is no metadata #38713

Closed
wants to merge 1 commit into from
Closed

fix(localize): render location in XLIFF 2 even if there is no metadata #38713

wants to merge 1 commit into from

Conversation

petebacondarwin
Copy link
Member

Previously, the location of a translation message, in XLIFF 2, was only
rendered if there were also notes for meaning or description. Now the
location will be rendered even if the other metadata is not provided.

Fixes #38705

@petebacondarwin petebacondarwin added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n target: patch This PR is targeted for the next patch release engine: ivy labels Sep 4, 2020
@ngbot ngbot bot modified the milestone: needsTriage Sep 4, 2020
@petebacondarwin
fix(localize): render location in XLIFF 2 even if there is no metadata
1489cc3 
Previously, the location of a translation message, in XLIFF 2, was only
rendered if there were also notes for meaning or description. Now the
location will be rendered even if the other metadata is not provided.

Fixes angular#38705
AndrewKushnir
AndrewKushnir approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 4, 2020
@petebacondarwin petebacondarwin added the action: merge The PR is ready for merge by the caretaker label Sep 4, 2020
atscott pushed a commit that referenced this pull request Sep 8, 2020
@petebacondarwin @atscott
fix(localize): render location in XLIFF 2 even if there is no metadata (
ab4f953 
#38713)

Previously, the location of a translation message, in XLIFF 2, was only
rendered if there were also notes for meaning or description. Now the
location will be rendered even if the other metadata is not provided.

Fixes #38705

PR Close #38713
@atscott atscott closed this in 92ff6d9 Sep 8, 2020
@petebacondarwin petebacondarwin deleted the i18n-xliff2-location-bug branch September 8, 2020 20:41
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: i18n cla: yes target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

Extractor no longer extracts the location if i18n is without parameters
3 participants
@petebacondarwin @AndrewKushnir @googlebot