Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(localize): ensure that formatOptions is optional #38787

Conversation

petebacondarwin
Copy link
Member

Some lower level APIs are used by CLI, and requiring
the formatOpions argument at that level is a
breaking change. This commit makes it optional
at every level to avoid the breaking change.

Some lower level APIs are used by CLI, and requiring
the `formatOpions` argument at that level is a
breaking change. This commit makes it optional
at every level to avoid the breaking change.
@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n regression Indicates than the issue relates to something that worked in a previous version target: patch This PR is targeted for the next patch release type: bug/fix labels Sep 10, 2020
@ngbot ngbot bot modified the milestone: needsTriage Sep 10, 2020
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 10, 2020
AndrewKushnir pushed a commit that referenced this pull request Sep 10, 2020
Some lower level APIs are used by CLI, and requiring
the `formatOpions` argument at that level is a
breaking change. This commit makes it optional
at every level to avoid the breaking change.

PR Close #38787
alan-agius4 added a commit to angular/angular-cli that referenced this pull request Sep 11, 2020
clydin pushed a commit to angular/angular-cli that referenced this pull request Sep 11, 2020
@petebacondarwin petebacondarwin deleted the i18n-make-formatOptions-optional branch September 19, 2020 08:49
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: i18n cla: yes regression Indicates than the issue relates to something that worked in a previous version target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants