Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(language-service): implement go to definition for style and template urls #39202

Closed
wants to merge 2 commits into from
Closed

feat(language-service): implement go to definition for style and template urls #39202

wants to merge 2 commits into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Oct 9, 2020

…late urls

This commit enables the Ivy Language Service to "go to definition" of a
templateUrl or styleUrl, which would jump to the template/style file
itself.

@atscott atscott added action: review The PR is still awaiting reviews from at least one requested reviewer area: language-service Issues related to Angular's VS Code language service target: minor This PR is targeted for the next minor release labels Oct 9, 2020
@ngbot ngbot bot modified the milestone: needsTriage Oct 9, 2020
@google-cla google-cla bot added the cla: yes label Oct 9, 2020
@pullapprove pullapprove bot requested a review from gkalpak October 9, 2020 18:24
@atscott atscott added this to PRs In Review in Ivy Language Service Oct 9, 2020
@atscott atscott changed the title Gototemplatedefinition feat(language-service): implement go to definition for style and template urls Oct 9, 2020
@atscott atscott force-pushed the gototemplatedefinition branch 4 times, most recently from ca4bc74 to 61419cb Compare October 12, 2020 18:06
kyliau
kyliau reviewed Oct 13, 2020
View reviewed changes
packages/language-service/common/definitions.ts Outdated Show resolved Hide resolved
packages/language-service/ivy/language_service.ts Outdated Show resolved Hide resolved
packages/language-service/ivy/language_service.ts Outdated Show resolved Hide resolved
packages/language-service/ivy/language_service.ts Outdated Show resolved Hide resolved
@atscott atscott force-pushed the gototemplatedefinition branch 4 times, most recently from d3f69ab to b35a196 Compare October 14, 2020 16:55
kyliau
kyliau approved these changes Oct 14, 2020
View reviewed changes
packages/language-service/common/definitions.ts Outdated Show resolved Hide resolved
@atscott atscott force-pushed the gototemplatedefinition branch 3 times, most recently from b8feca2 to 3eccefa Compare October 15, 2020 18:58
@atscott atscott removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 15, 2020
@atscott atscott added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 15, 2020
josephperrott
josephperrott approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: dev-infra

@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 15, 2020
@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Oct 15, 2020
@AndrewKushnir
Copy link
Contributor

@atscott it looks like there is a legit CI failure, could you please have a look when you get a chance (replacing "merge" with "cleanup" label for now)? Thank you.

@atscott
refactor(language-service): Move some util functions to common
ed53a78 
These functions will be useful to the Ivy language service as well to
provide 'go to definition' functionality for template and style urls.
@atscott
feat(language-service): Implement go to definition for style and temp…
58b421b 
…late urls

This commit enables the Ivy Language Service to 'go to definition' of a
templateUrl or styleUrl, which would jump to the template/style file
itself.
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 15, 2020
AndrewKushnir pushed a commit that referenced this pull request Oct 16, 2020
@atscott @AndrewKushnir
feat(language-service): Implement go to definition for style and temp…
563fb6c 
…late urls (#39202)

This commit enables the Ivy Language Service to 'go to definition' of a
templateUrl or styleUrl, which would jump to the template/style file
itself.

PR Close #39202
@atscott atscott moved this from PRs In Review to Done in Ivy Language Service Oct 19, 2020
atscott added a commit to atscott/angular that referenced this pull request Oct 26, 2020
@atscott
Revert "refactor(language-service): Move some util functions to common (
7f13ba2 
angular#39202)"

This reverts commit 087596b
atscott added a commit to atscott/angular that referenced this pull request Oct 26, 2020
@atscott
Revert "refactor(language-service): Move some util functions to common (
4766fe5 
angular#39202)"

This reverts commit 087596b
atscott added a commit to atscott/angular that referenced this pull request Oct 26, 2020
@atscott
Revert "refactor(language-service): Move some util functions to common (
57232f3 
angular#39202)"

This reverts commit 087596b
atscott added a commit to atscott/angular that referenced this pull request Oct 28, 2020
@atscott
Revert "refactor(language-service): Move some util functions to common (
051864c 
angular#39202)"

This reverts commit 087596b
atscott added a commit to atscott/angular that referenced this pull request Oct 28, 2020
@atscott
Revert "refactor(language-service): Move some util functions to common (
d586ace 
angular#39202)"

This reverts commit 087596b
atscott added a commit to atscott/angular that referenced this pull request Oct 28, 2020
@atscott
Revert "refactor(language-service): Move some util functions to common (
eaa1075 
angular#39202)"

This reverts commit 087596b
atscott added a commit to atscott/angular that referenced this pull request Oct 28, 2020
@atscott
Revert "refactor(language-service): Move some util functions to common (
6198afd 
angular#39202)"

This reverts commit 087596b
atscott added a commit to atscott/angular that referenced this pull request Oct 28, 2020
@atscott
Revert "refactor(language-service): Move some util functions to common (
675acf1 
angular#39202)"

This reverts commit 087596b
atscott added a commit to atscott/angular that referenced this pull request Oct 30, 2020
@atscott
Revert "refactor(language-service): Move some util functions to common (
2268adf 
angular#39202)"

This reverts commit 087596b
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kyliau kyliau kyliau approved these changes

@josephperrott josephperrott josephperrott approved these changes

@ayazhafiz ayazhafiz ayazhafiz approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service cla: yes target: minor This PR is targeted for the next minor release
Projects
No open projects
Ivy Language Service
  
Done
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@atscott @AndrewKushnir @kyliau @josephperrott @ayazhafiz