Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): recover expression parsing in more malformed pipe cases #39437

Closed
wants to merge 1 commit into from
Closed

feat(compiler): recover expression parsing in more malformed pipe cases #39437

wants to merge 1 commit into from

Conversation

ayazhafiz
Copy link
Member

This commit handles the following cases:

  • incomplete pipes in a pipe chain
  • incomplete arguments in a pipe chain
  • incomplete arguments provided to a pipe
  • nested pipes

The idea is to unconditionally recover on the presence of a pipe, which
should be okay because expression parsing can be independently between
pipes.

@ayazhafiz
feat(compiler): recover expression parsing in more malformed pipe cases
5a62fcc 
This commit handles the following cases:
- incomplete pipes in a pipe chain
- incomplete arguments in a pipe chain
- incomplete arguments provided to a pipe
- nested pipes

The idea is to unconditionally recover on the presence of a pipe, which
should be okay because expression parsing can be independently between
pipes.
@ayazhafiz ayazhafiz added target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 26, 2020
@ayazhafiz ayazhafiz requested a review from alxhub October 26, 2020 22:44
@ngbot ngbot bot added this to the needsTriage milestone Oct 26, 2020
@google-cla google-cla bot added the cla: yes label Oct 26, 2020
atscott
atscott approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great suite of tests and organization of the documentation

@alxhub alxhub added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Oct 29, 2020
@ayazhafiz ayazhafiz added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Oct 29, 2020
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Oct 29, 2020
@ayazhafiz
Copy link
Member Author

Caretaker: can you run g3sync?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott atscott approved these changes

@alxhub alxhub alxhub approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ayazhafiz @atscott @alxhub