fix(core): remove duplicated noop function #39761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The codebase currently contains several `noop` functions, and they can end up in the bundle of an application. A recent commit 6fbe219 tipped us off as it introduced several `noop` occurrences in the golden symbol files. After investigating with @petebacondarwin, we decided to remove the duplicated functions. This probably shaves only a few bytes, but this commit removes the duplicated functions, by always using the one in `core/src/utils/noop`.
petebacondarwin
added
action: review
petebacondarwin
approved these changes
Nov 19, 2020
mhevery
approved these changes
Nov 19, 2020
mhevery
added
action: merge
mhevery
approved these changes
Nov 19, 2020
AndrewKushnir
pushed a commit
that referenced
this pull request
Nov 19, 2020
The codebase currently contains several `noop` functions, and they can end up in the bundle of an application. A recent commit 6fbe219 tipped us off as it introduced several `noop` occurrences in the golden symbol files. After investigating with @petebacondarwin, we decided to remove the duplicated functions. This probably shaves only a few bytes, but this commit removes the duplicated functions, by always using the one in `core/src/utils/noop`. PR Close #39761
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The codebase currently contains several
noopfunctions,and they can end up in the bundle of an application.
A recent commit 6fbe219 tipped us off
as it introduced several
noopoccurrences in the golden symbol files.After investigating with @petebacondarwin,
we decided to remove the duplicated functions.
What is the new behavior?
This probably shaves only a few bytes,
but this commit removes the duplicated functions,
by always using the one in
core/src/utils/noop.Does this PR introduce a breaking change?