Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): migration incorrectly replacing deprecated key #39763

Closed
wants to merge 1 commit into from
Closed

fix(router): migration incorrectly replacing deprecated key #39763

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

In #38762 we added a migration to replace the deprecated preserveQueryParams option with queryParamsHandling, however due to a typo, we ended up replacing it with queryParamsHandler which is invalid.

Fixes #39755.

@crisbeto
fix(router): migration incorrectly replacing deprecated key
8090289 
In angular#38762 we added a migration to replace the deprecated `preserveQueryParams`
option with `queryParamsHandling`, however due to a typo, we ended up replacing it
with `queryParamsHandler` which is invalid.

Fixes angular#39755.
@google-cla google-cla bot added the cla: yes label Nov 19, 2020
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: migrations Issues related to `ng update` migrations target: patch This PR is targeted for the next patch release type: bug/fix labels Nov 19, 2020
@crisbeto crisbeto marked this pull request as ready for review November 19, 2020 16:57
@ngbot ngbot bot modified the milestone: needsTriage Nov 19, 2020
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 19, 2020
AndrewKushnir pushed a commit that referenced this pull request Nov 19, 2020
@crisbeto @AndrewKushnir
fix(router): migration incorrectly replacing deprecated key (#39763)
0237845 
In #38762 we added a migration to replace the deprecated `preserveQueryParams`
option with `queryParamsHandling`, however due to a typo, we ended up replacing it
with `queryParamsHandler` which is invalid.

Fixes #39755.

PR Close #39763
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott atscott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update` migrations cla: yes target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

Invalid preserveQueryParams migration with v11
2 participants
@crisbeto @atscott