Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some error messages hard-code v9.angular.io after v11 #39837

Closed
1 of 15 tasks
ghost opened this issue Nov 25, 2020 · 3 comments
Closed
1 of 15 tasks

Some error messages hard-code v9.angular.io after v11 #39837

ghost opened this issue Nov 25, 2020 · 3 comments
Labels
help wanted An issue that is suitable for a community contributor (based on its complexity/scope). P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent state: has PR
Milestone

Comments

@ghost
Copy link

ghost commented Nov 25, 2020

馃悶 Bug report

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • extract-i18n
  • run
  • config
  • help
  • version
  • doc

Is this a regression?

Kind of.

Description

I ran into an error:

Error: ngcc is already running at process with id 11332.
If you are running multiple builds in parallel then you should pre-process your node_modules via the command line ngcc tool before starting the builds;
See https://v9.angular.io/guide/ivy#speeding-up-ngcc-compilation.
(If you are sure no ngcc process is running then you should delete the lock-file at C:/Work/frontend/node_modules/@angular/compiler-cli/ngcc/__ngcc_lock_file__.)
  1. The link https://v9.angular.io/guide/ivy#speeding-up-ngcc-compilation points to the archived documentation for Angular v9
  2. Even in the archived documentation there is nothing related to the error, there are no instructions about pre-processing the node_modules.

馃敩 Minimal Reproduction

Remove node_modules, run npm ci, start ng build and ng test at the same time

馃實 Your Environment

Angular CLI: 11.0.2
Node: 12.16.1
OS: win32 x64

Angular: 11.0.2
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, localize, platform-browser
... platform-browser-dynamic, router, service-worker
Ivy Workspace: Yes

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1100.2
@angular-devkit/build-angular   0.1100.2
@angular-devkit/core            11.0.2
@angular-devkit/schematics      11.0.2
@angular/cdk                    11.0.1
@angular/google-maps            11.0.1
@schematics/angular             11.0.2
@schematics/update              0.1100.2
rxjs                            6.6.3
typescript                      4.0.5
@alan-agius4 alan-agius4 transferred this issue from angular/angular-cli Nov 25, 2020
@ngbot ngbot bot added this to the needsTriage milestone Nov 25, 2020
@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Dec 2, 2020
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Dec 2, 2020
@jelbourn jelbourn changed the title Outdated link in error message Some error messages hard-code v9.angular.io after v11 Dec 2, 2020
@jelbourn jelbourn added the help wanted An issue that is suitable for a community contributor (based on its complexity/scope). label Dec 2, 2020
@bgotink
Copy link

bgotink commented Dec 10, 2020

In my opinion the current issue title hides the actual problem here. The biggest problem for me isn't that the link points to v9, the biggest problem is that the link points to a page that doesn't contain the information the error message is referring to.

Updating the link to the v11 docs doesn't solve the problem, that page still doesn't contain the relevant information.

Googling speeding-up-ngcc-compilation yields a PR build of the aio website that does contain the relevant section: https://pr34900-985c0b4.ngbuilds.io/guide/ivy#speeding-up-ngcc-compilation.

@petebacondarwin
Copy link
Member

I think that is a very good point @bgotink. This section of the docs only existed transiently. It was added at 9.1.0-next.0 (9a840e5) and removed at 9.1.0-next.5 (4a9514e). But the error that mentions it was not cleaned up.

petebacondarwin added a commit to petebacondarwin/angular that referenced this issue Dec 31, 2020
The link to the "speeding-up-ngcc-compilation" URL does not exist,
it was removed shortly after it was added, but the link in the ngcc
error message was not updated.

Fixes angular#39837
josephperrott pushed a commit that referenced this issue Jan 6, 2021
The link to the "speeding-up-ngcc-compilation" URL does not exist,
it was removed shortly after it was added, but the link in the ngcc
error message was not updated.

Fixes #39837

PR Close #40285
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted An issue that is suitable for a community contributor (based on its complexity/scope). P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent state: has PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants