fix(compiler): recover event parse when animation event name is empty

[ivanwonder]

Now when the animation trigger output event is missing its phase value name, the BoundEvent will be ignored, but it's useful for completion in language service.

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• angular.io application / infrastructure changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

[ayazhafiz]

I think it may be helpful to merge this expect with the last test.

Also, could you add tests for when the phase is not start or done, or missing?

[ayazhafiz]

I don't think you need this outer conditional anymore.

[ivanwonder]

angular/packages/compiler/src/template_parser/binding_parser.ts

Lines 418 to 432 in 12f12ff

	parseEvent(
	name: string, expression: string, sourceSpan: ParseSourceSpan, handlerSpan: ParseSourceSpan,
	targetMatchableAttrs: string[][], targetEvents: ParsedEvent[], keySpan?: ParseSourceSpan) {
	if (name.length === 0) {
	this._reportError(`Event name is missing in binding`, sourceSpan);
	}
	if (isAnimationLabel(name)) {
	name = name.substr(1);
	this._parseAnimationEvent(name, expression, sourceSpan, handlerSpan, targetEvents, keySpan);
	} else {
	this._parseRegularEvent(
	name, expression, sourceSpan, handlerSpan, targetMatchableAttrs, targetEvents, keySpan);
	}
	}

But I think the conditional here doesn't work for animation events. Maybe it should be moved into _parseRegularEvent. So the conditional for animation event should be added here.

[JoostK]

LGTM, just one comment.

[JoostK]

Could you add another expect without the period?

[ivanwonder]

Sorry, I don't understand what the another expect is. Do you mean merge this expect into the last test?

[JoostK]

Sorry, what I meant was to duplicate this expectation to verify a template which omits the period:

expect(() => parse('<div (@event)></div>'))

Does that make sense?

[ivanwonder]

Thanks, done.

[AndrewKushnir]

Presubmit.

[atscott]

FYI - This is merging to master branch only. I'll create a separate PR to merge to 11.0.x

Edit: Because the reason for this PR is to accommodate the language service, I think it's okay to only merge to master which targets the 11.1 release.

[ivanwonder]

FYI - This is merging to master branch only. I'll create a separate PR to merge to 11.0.x

Edit: Because the reason for this PR is to accommodate the language service, I think it's okay to only merge to master which targets the 11.1 release.

Yes, it's okay to only merge to master.
This is the other PR I try to provide the animation completions.
#40347 #40300

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}