feat(language-service): enable get references for directive and compo… #40054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
action: review
atscott
force-pushed
the
findReferencesComponentTag
branch
from
1008d58
to
c809e27
Compare
kyliau
approved these changes
Dec 10, 2020
kyliau
added
action: cleanup
…nent from template This commit adds the ability to find references for a directive or component from within a component template. That is, you can find component references from the element tag `<my-c|omp></my-comp>` (where `|` is the cursor position) as well as find references for directives that match a given attribute `<div d|ir></div>`.
atscott
force-pushed
the
findReferencesComponentTag
branch
from
c809e27
to
7773adf
Compare
atscott
added
action: merge
zarend
pushed a commit
to zarend/angular
that referenced
this pull request
Dec 11, 2020
…nent from template (angular#40054) This commit adds the ability to find references for a directive or component from within a component template. That is, you can find component references from the element tag `<my-c|omp></my-comp>` (where `|` is the cursor position) as well as find references for directives that match a given attribute `<div d|ir></div>`. PR Close angular#40054
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nent from template
This commit adds the ability to find references for a directive or component
from within a component template. That is, you can find component references
from the element tag
<my-c|omp></my-comp>(where|is the cursor position)as well as find references for directives that match a given attribute
<div d|ir></div>.