fix(language-service): force compileNonExportedClasses: false in LS #40092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Projects opened in the LS are often larger in scope than the compilation units seen by the compiler when actually building. For example, in the LS it's not uncommon for the project to include both application as well as test files. This can create issues when the combination of files results in errors that are not otherwise present - for example, if test files have inline NgModules that re-declare components (a common Angular pattern). Such code is valid when compiling the app only (test files are excluded, so only one declaration is seen by the compiler) or when compiling tests only (since tests run in JIT mode and are not seen by the AOT compiler), but when both sets of files are mixed into a single compilation unit, the compiler sees the double declaration as an error. This commit attempts to mitigate the problem by forcing the compiler flag `compileNonExportedClasses` to `false` in a LS context. When tests contain duplicate declarations, often such declarations are inline in specs and not exported from the top level, so this flag can be used to greatly improve the IDE experience.
pullapprove
bot
added
area: language-service
|
|
atscott
approved these changes
Dec 11, 2020
alxhub
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projects opened in the LS are often larger in scope than the compilation
units seen by the compiler when actually building. For example, in the LS
it's not uncommon for the project to include both application as well as
test files. This can create issues when the combination of files results
in errors that are not otherwise present - for example, if test files
have inline NgModules that re-declare components (a common Angular pattern).
Such code is valid when compiling the app only (test files are excluded, so
only one declaration is seen by the compiler) or when compiling tests only
(since tests run in JIT mode and are not seen by the AOT compiler), but when
both sets of files are mixed into a single compilation unit, the compiler
sees the double declaration as an error.
This commit attempts to mitigate the problem by forcing the compiler flag
compileNonExportedClassestofalsein a LS context. When tests containduplicate declarations, often such declarations are inline in specs and not
exported from the top level, so this flag can be used to greatly improve the
IDE experience.