fix(core): ensure sanitizer works if DOMParser return null body #40107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
added
action: review
pullapprove
bot
requested review from
IgorMinar,
jelbourn,
jessicajaniuk and
mhevery
In some browsers, notably a mobile version of webkit on iPad, the result of calling `DOMParser.parseFromString()` returns a document whose `body` property is null until the next tick of the browser. Since this is of no use to us for sanitization, we now fall back to the "inert document" strategy for this case. Fixes angular#39834
petebacondarwin
force-pushed
the
sanitizer-issue-39834
branch
from
705beec
to
36ed960
Compare
|
@koto can you take a look too? |
JoostK
reviewed
Dec 14, 2020
mhevery
approved these changes
Dec 14, 2020
petebacondarwin
added
the
action: presubmit
|
From a security point of view, I want to know whether there are situations where the inert document helper should not be used even if the DOMParser helper fails... |
Not to my knowledge. LGTM. |
zarend
approved these changes
Dec 15, 2020
jelbourn
approved these changes
Dec 22, 2020
IgorMinar
approved these changes
Jan 5, 2021
IgorMinar
added
action: merge
AndrewKushnir
removed
the
action: presubmit
josephperrott
pushed a commit
that referenced
this pull request
Jan 6, 2021
In some browsers, notably a mobile version of webkit on iPad, the result of calling `DOMParser.parseFromString()` returns a document whose `body` property is null until the next tick of the browser. Since this is of no use to us for sanitization, we now fall back to the "inert document" strategy for this case. Fixes #39834 PR Close #40107
|
@petebacondarwin This fix is amazing. Thank you. It reduced my exception metric by 90%... seriously. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some browsers, notably a mobile version of webkit on iPad, the
result of calling
DOMParser.parseFromString()returns a documentwhose
bodyproperty is null until the next tick of the browser.Since this is of no use to us for sanitization, we now fall back to the
"inert document" strategy for this case.
Fixes #39834