feat(compiler-cli): JIT compilation of component declarations #40127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
added
state: WIP
area: compiler
JoostK
force-pushed
the
linker/components_jit
branch
from
a551632
to
3a06049
Compare
JoostK
force-pushed
the
linker/components_jit
branch
5 times, most recently
from
557e067
to
e685467
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
JoostK
force-pushed
the
linker/components_jit
branch
from
e685467
to
74545fe
Compare
JoostK
force-pushed
the
linker/components_jit
branch
from
74545fe
to
1da1beb
Compare
pullapprove
bot
added
area: core
JoostK
added
action: review
pullapprove
bot
added
the
area: dev-infra
JoostK
requested review from
petebacondarwin
and removed request for
atscott
petebacondarwin
approved these changes
Dec 25, 2020
There was a problem hiding this comment.
Another marvellous PR @JoostK - just a couple of nits and bike-sheds.
petebacondarwin
added
the
action: cleanup
JoostK
force-pushed
the
linker/components_jit
branch
from
1da1beb
to
62f7981
Compare
JoostK
added
action: merge
The `render3` test targets are currently also executed for ViewEngine builds, even though the `render3` infrastructure only concerns Ivy infrastructure. This commit tags the test targets as ivy-only to disable those tests for View Engine.
The `ɵɵngDeclareComponent` calls are designed to be translated to fully AOT compiled code during a build transform, but in cases this is not done it is still possible to compile the declaration object in the browser using the JIT compiler. This commit adds a runtime implementation of `ɵɵngDeclareComponent` which invokes the JIT compiler using the declaration object, such that a compiled component definition is made available to the Ivy runtime.
JoostK
force-pushed
the
linker/components_jit
branch
from
62f7981
to
b5b2b9e
Compare
josephperrott
pushed a commit
that referenced
this pull request
Jan 6, 2021
The `ɵɵngDeclareComponent` calls are designed to be translated to fully AOT compiled code during a build transform, but in cases this is not done it is still possible to compile the declaration object in the browser using the JIT compiler. This commit adds a runtime implementation of `ɵɵngDeclareComponent` which invokes the JIT compiler using the declaration object, such that a compiled component definition is made available to the Ivy runtime. PR Close #40127
JoostK
added a commit
to JoostK/angular
that referenced
this pull request
Jan 7, 2021
…ction name The "monitoring" workflow is has been failing since angular#40127 was merged, due to a Saucelabs test failure in Internet Explorer 11. The issue is with the test's expectation which does not account for Ivy instruction invocations to use "anonymous" instead of the instruction's function name. This commit changes the test expectation to also accept "anonymous", which was already the case for similar expectations.
JoostK
added a commit
to JoostK/angular
that referenced
this pull request
Jan 7, 2021
…ction name The "monitoring" workflow has been failing since angular#40127 was merged, due to a Saucelabs test failure in Internet Explorer 11. The issue is with the test's expectation which does not account for Ivy instruction invocations to use "anonymous" instead of the instruction's function name. This commit changes the test expectation to also accept "anonymous", which was already the case for similar expectations.
atscott
pushed a commit
that referenced
this pull request
Jan 7, 2021
…ction name (#40342) The "monitoring" workflow has been failing since #40127 was merged, due to a Saucelabs test failure in Internet Explorer 11. The issue is with the test's expectation which does not account for Ivy instruction invocations to use "anonymous" instead of the instruction's function name. This commit changes the test expectation to also accept "anonymous", which was already the case for similar expectations. PR Close #40342
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ɵɵngDeclareComponentcalls are designed to be translated to fullyAOT compiled code during a build transform, but in cases this is not
done it is still possible to compile the declaration object in the
browser using the JIT compiler. This commit adds a runtime
implementation of
ɵɵngDeclareComponentwhich invokes the JIT compilerusing the declaration object, such that a compiled component definition
is made available to the Ivy runtime.