fix(core): error if detectChanges is called at the wrong time under specific circumstances

[crisbeto]

Internally we store lifecycle hooks in the format [index, hook, index, hook] and when iterating over them, we check one place ahead to figure out whether we've hit found a hook or an index. The problem is that the loop is set up to iterate up to hooks.length which means that we may go out of bounds on the last iteration, depending on where we started. This appears to happen under a specific set of circumstances where a directive calls detectChanges from an input setter while it has ngOnChanges and ngAfterViewInit hooks.

These changes resolve the issue by only iterating up to length - 1 which guarantees that we can always look one place ahead.

This appears to have regressed some time in version 10.

Fixes #38611.

[crisbeto]

Note for reviewer: the ci/circleci: test appears to be a known failure that is happening in other PRs as well.

[atscott]

presubmit

[ngbot]

I see that you just added the action: merge label, but the following checks are still failing:
     status "ci/circleci: test" is failing
     status "google3" is pending
     missing required status "ci/circleci: publish_snapshot"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}