fix(core): memory leak if view container host view is destroyed while view ref is not #40219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
38648-view-container-ref-leak
branch
2 times, most recently
from
7e2367c
to
30d0d5b
Compare
crisbeto
added
action: review
… view ref is not When we attach a `ViewRef` to a `ViewContainerRef`, we save a reference to the container onto the `ViewRef` so that we can remove it when the ref is destroyed. The problem is that if the container's `hostView` is destroyed first, the `ViewRef` has no way of knowing that it should stop referencing the container. These changes remove the leak by not saving a reference at all. Instead, when a `ViewRef` is destroyed, we clean it up through the `LContainer` directly. We don't need to worry about the case where the container is destroyed before the view, because containers automatically clean up all of their views upon destruction. Fixes angular#38648.
crisbeto
force-pushed
the
38648-view-container-ref-leak
branch
from
30d0d5b
to
f82f03d
Compare
mhevery
approved these changes
Jan 7, 2021
| "packages/core/src/error_handler.ts", | ||
| "packages/core/src/errors.ts", | ||
| "packages/core/src/view/types.ts", | ||
| "packages/core/src/linker/component_factory.ts" |
There was a problem hiding this comment.
Always a good sign when bunch of circular refs get removed!
❤️
AndrewKushnir
approved these changes
Jan 7, 2021
AndrewKushnir
added
action: presubmit
AndrewKushnir
removed
the
action: presubmit
atscott
pushed a commit
that referenced
this pull request
Jan 8, 2021
… view ref is not (#40219) When we attach a `ViewRef` to a `ViewContainerRef`, we save a reference to the container onto the `ViewRef` so that we can remove it when the ref is destroyed. The problem is that if the container's `hostView` is destroyed first, the `ViewRef` has no way of knowing that it should stop referencing the container. These changes remove the leak by not saving a reference at all. Instead, when a `ViewRef` is destroyed, we clean it up through the `LContainer` directly. We don't need to worry about the case where the container is destroyed before the view, because containers automatically clean up all of their views upon destruction. Fixes #38648. PR Close #40219
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we attach a
ViewRefto aViewContainerRef, we save a reference to the container onto theViewRefso that we can remove it when the ref is destroyed. The problem is that if the container'shostViewis destroyed first, theViewRefhas no way of knowing that it should stop referencing the container.These changes remove the leak by not saving a reference at all. Instead, when a
ViewRefis destroyed, we clean it up through theLContainerdirectly. We don't need to worry about the case where the container is destroyed before the view, because containers automatically clean up all of their views upon destruction.Fixes #38648.