fix(compiler): incorrectly encapsulating selectors with escape sequences #40264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
added
the
area: compiler
crisbeto
added
action: review
pullapprove
bot
added
the
area: compiler
AndrewKushnir
approved these changes
Jan 6, 2021
AndrewKushnir
added
the
action: presubmit
CSS supports escaping in selectors, e.g. writing `.foo:bar` will match an element with the `foo` class and `bar` pseudo-class, but `.foo\:bar` will match the `foo:bar` class. Our shimmed shadow DOM encapsulation always assumes that `:` means a pseudo selector which breaks a selector like `.foo\:bar`. These changes add some extra logic so that escaped characters in selectors are preserved. Fixes angular#31844.
crisbeto
added
action: merge
crisbeto
force-pushed
the
31844-encapsulation-escape-characters
branch
from
053232c
to
79c12bb
Compare
AndrewKushnir
removed
the
action: presubmit
josephperrott
pushed a commit
that referenced
this pull request
Jan 6, 2021
…ces (#40264) CSS supports escaping in selectors, e.g. writing `.foo:bar` will match an element with the `foo` class and `bar` pseudo-class, but `.foo\:bar` will match the `foo:bar` class. Our shimmed shadow DOM encapsulation always assumes that `:` means a pseudo selector which breaks a selector like `.foo\:bar`. These changes add some extra logic so that escaped characters in selectors are preserved. Fixes #31844. PR Close #40264
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS supports escaping in selectors, e.g. writing
.foo:barwill match an element with thefooclass andbarpseudo-class, but.foo\:barwill match thefoo:barclass. Our shimmed shadow DOM encapsulation always assumes that:means a pseudo selector which breaks a selector like.foo\:bar.These changes add some extra logic so that escaped characters in selectors are preserved.
Fixes #31844.