fix(compiler): correct the KeySpan for animation events and properties
#40347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
atscott
added
the
area: compiler
atscott
requested changes
Jan 11, 2021
There was a problem hiding this comment.
LGTM with a minor nit in the compiler code style
Also, could you please update the commit message to better describe what this change is? It's not clear what the existing behavior is and what this commit will change it to be. It also doesn't describe why this change is more correct.
Thanks!
atscott
added
target: patch
ivanwonder
force-pushed
the
keyspan-for-animation
branch
from
c244b04
to
0d53ae3
Compare
We should provide the completion when the cursor is in the attribute name after the `@` and `animate-`, but now the `KeySpan` starts from the `@` or `animate-`. For example, the animation event `(@name.done)="v"`, we can know where the cursor is by the `KeySpan` of `name.done` exactly, it's in the event name or in the phase name.
ivanwonder
force-pushed
the
keyspan-for-animation
branch
from
0d53ae3
to
d986d55
Compare
atscott
reviewed
Jan 13, 2021
atscott
added
target: rc
alxhub
approved these changes
Jan 14, 2021
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 15, 2021
…ies (#40347) We should provide the completion when the cursor is in the attribute name after the `@` and `animate-`, but now the `KeySpan` starts from the `@` or `animate-`. For example, the animation event `(@name.done)="v"`, we can know where the cursor is by the `KeySpan` of `name.done` exactly, it's in the event name or in the phase name. PR Close #40347
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the
KeySpanfor animation includes@,animate-,this PR will correct the position.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information