Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log compiler options #40364

Closed
wants to merge 2 commits into from
Closed

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Jan 8, 2021

Please see individual commit messages:

  1. fix(language-service): reinstate overridden compiler option after change

    Currently the language service has to force compileNonExportedClasses to
    true to handle inline NgModules in tests, regardless of the value in user's
    tsconfig.json.

    However, the override is not reinstated after the compiler option changes
    (triggered by a change in tsconfig.json).
    This commit fixes the bug.

  2. feat(language-service): log Angular compiler options

    This commit records the Angular compiler options in the log file to help
    debugging.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Currently the language service has to force `compileNonExportedClasses` to
`true` to handle inline NgModules in tests, regardless of the value in user's
tsconfig.json.

However, the override is not reinstated after the compiler option changes
(triggered by a change in tsconfig.json).
This commit fixes the bug.
This commit records the Angular compiler options in the log file to help
debugging.
@kyliau kyliau added area: language-service Issues related to Angular's VS Code language service target: minor This PR is targeted for the next minor release labels Jan 8, 2021
@kyliau kyliau requested a review from atscott January 8, 2021 18:43
@ngbot ngbot bot modified the milestone: Backlog Jan 8, 2021
@google-cla google-cla bot added the cla: yes label Jan 8, 2021
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Jan 8, 2021
@atscott atscott closed this in 811cacc Jan 8, 2021
atscott pushed a commit that referenced this pull request Jan 8, 2021
This commit records the Angular compiler options in the log file to help
debugging.

PR Close #40364
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service cla: yes target: minor This PR is targeted for the next minor release
Projects
No open projects
Ivy Language Service
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants