Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): diagnostic and definition should work for absolute url #40406

Closed
wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Jan 13, 2021

This commit fixes a bug in the View Engine implementation of
getSemanticDiagnostics and getDefinitionAndBoundSpan for node in the
decorator metadata that represents an external URL
(templateUrl or styleUrls).

The URL could be either relative or absolute, but the latter was not taken
into account.

Fix angular/vscode-ng-language-service#1055

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

…lute url

This commit fixes a bug in the **View Engine** implementation of
`getSemanticDiagnostics` and `getDefinitionAndBoundSpan` for node in the
decorator metadata that represents an external URL
(`templateUrl` or `styleUrls`).

The URL could be either relative or absolute, but the latter was not taken
into account.

Fix angular/vscode-ng-language-service#1055
@kyliau kyliau added area: language-service Issues related to Angular's VS Code language service target: patch This PR is targeted for the next patch release labels Jan 13, 2021
@kyliau kyliau requested a review from atscott January 13, 2021 00:10
@ngbot ngbot bot added this to the Backlog milestone Jan 13, 2021
@google-cla google-cla bot added the cla: yes label Jan 13, 2021
@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Jan 13, 2021
@atscott atscott added this to Done in Ivy Language Service Jan 13, 2021
@atscott atscott added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jan 13, 2021
@atscott atscott closed this in 625d2c2 Jan 13, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service cla: yes target: minor This PR is targeted for the next minor release
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Angular Language Service does not recognize absolute urls
2 participants