Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix fakeAsync() error messages #40442

Closed
wants to merge 1 commit into from
Closed

fix(core): fix fakeAsync() error messages #40442

wants to merge 1 commit into from

Conversation

JiaLiPassion
Copy link
Contributor

Fix error messages when calling fakeAsync() without importing zone-testing.js

@JiaLiPassion
fix(core): fix fakeAsync() error messages
96e4eb4 
Fix error messages when calling `fakeAsync()` without importing `zone-testing.js`
@google-cla google-cla bot added the cla: yes label Jan 15, 2021
@ngbot ngbot bot added this to the Backlog milestone Jan 15, 2021
@JiaLiPassion JiaLiPassion added target: minor This PR is targeted for the next minor release risk: low labels Jan 15, 2021
@JiaLiPassion JiaLiPassion removed the request for review from mhevery January 15, 2021 06:38
@AndrewKushnir AndrewKushnir added target: rc This PR is targeted for the next release-candidate and removed target: minor This PR is targeted for the next minor release labels Jan 17, 2021
AndrewKushnir
AndrewKushnir approved these changes Jan 17, 2021
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AndrewKushnir AndrewKushnir added the action: presubmit The PR is in need of a google3 presubmit label Jan 17, 2021
@AndrewKushnir
Copy link
Contributor

Presubmit.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Jan 19, 2021
AndrewKushnir pushed a commit that referenced this pull request Jan 19, 2021
@JiaLiPassion @AndrewKushnir
fix(core): fix fakeAsync() error messages (#40442)
ad2b50b 
Fix error messages when calling `fakeAsync()` without importing `zone-testing.js`

PR Close #40442
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: zones cla: yes risk: low target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JiaLiPassion @AndrewKushnir