fix(common): fix currencyCode in CurrencyPipe

[vmohir]

When providing DEFAULT_CURRENCY_CODE, it's expected that the CurrenyPipe would pass it as currencyCode to formatCurrency function.

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• angular.io application / infrastructure changes
• Other... Please describe:

What is the current behavior?

Currently providing the DEFAULT_CURRENCY_CODE changes the symbol that's being displayed but it's not used inside the formatCurrency function for getting the minFrac (link to source code), therefore the default value (USD) is being used. So as an example, despite providing { provide: DEFAULT_CURRENCY_CODE, useValue: 'IRR' }, the code {{ 1000 | currency }} will result in 1,000.00 but it should be 1,000 based on this line

What is the new behavior?

With this change, the provided value for DEFAULT_CURRENCY_CODE will be passed as currencyCode to formatCurrency function.

Does this PR introduce a breaking change?

• Yes
• No

Other information

[petebacondarwin]

Thanks for this PR - this fix looks sound.
Could you please provide a unit test for this functionality by adding an it clause to the describe block at

angular/packages/common/test/pipes/number_pipe_spec.ts

Line 117 in 7b2aac9

describe('CurrencyPipe', () => {

[vmohir]

Done.
@petebacondarwin

[petebacondarwin]

Thanks for adding the test.

[petebacondarwin]

Thanks @gvmohzibat - we are getting there. Just a couple more tweaks.

[mhevery]

presubmit

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[petebacondarwin]

@googlebot I consent.

[AndrewKushnir]

Global Presubmit (internal-only link).

[AndrewKushnir]

Quick update after running tests in Google's codebase: this change is causing some internal tests to fail and more investigation is needed, so I'm adding the "blocked" label for now. We'll perform further investigation and keep this thread updated. Thank you.

[vmohir]

I'm not sure if I correctly rebased it. But I think it's good.

[jessicajaniuk]

LGTM 🍪

[AndrewKushnir]

Presubmit #2 + Global presubmit.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}