fix(forms): allow patchValue method of FormGroup and FormArray classes to skip null values
#40534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
type: bug/fix
state: WIP
area: forms
target: patch
petebacondarwin
approved these changes
Jan 23, 2021
There was a problem hiding this comment.
Fairly simple fix - LGTM.
I think there is a typo in the commit message:
...iterate over provided value...
->
...iterate over provided values...
Also (NITs):
- I prefer to add
()when mentioning functions in commit messages (e.g.patchValue()rather thanpatchValue) since it helps when scanning the text. - The bit in brackets
(for FormControl it's not a problem, since it doesn't have nested controls)could be moved to its own sentence after the end of this sentence, since it kind of gets in the way of the main description of the commit.
…` classes to skip `null` values Prior to this commit, the `patchValue()` of the `FormGroup` and `FormArray` classes used to throw an exception when the `value` argument contained a data structure that has `null` or `undefined` as a value for a field that represents an instance of `FormGroup` or `FormArray` (for `FormControl` it's not a problem, since it doesn't have nested controls), since the `patchValue()` method tried to iterate over provided values to match current data structure. This commit updates the `patchValue()` logic in `FormGroup` and `FormArray` classes to just ignore `null` and `undefined` values (without any changes to corresponding `FormGroup` and `FormArray` instances). This behavior looks inline with the `patchValue()` method goal of "doing its best to match the values to the correct controls" (quote from docs). Fixes angular#36672. Fixes angular#21021.
AndrewKushnir
added
action: presubmit
AndrewKushnir
force-pushed
the
forms_gh_36672
branch
from
d10e3f1
to
ac7985b
Compare
alfaproject
reviewed
Jan 25, 2021
AndrewKushnir
added
action: merge
jessicajaniuk
pushed a commit
that referenced
this pull request
Jan 25, 2021
…` classes to skip `null` values (#40534) Prior to this commit, the `patchValue()` of the `FormGroup` and `FormArray` classes used to throw an exception when the `value` argument contained a data structure that has `null` or `undefined` as a value for a field that represents an instance of `FormGroup` or `FormArray` (for `FormControl` it's not a problem, since it doesn't have nested controls), since the `patchValue()` method tried to iterate over provided values to match current data structure. This commit updates the `patchValue()` logic in `FormGroup` and `FormArray` classes to just ignore `null` and `undefined` values (without any changes to corresponding `FormGroup` and `FormArray` instances). This behavior looks inline with the `patchValue()` method goal of "doing its best to match the values to the correct controls" (quote from docs). Fixes #36672. Fixes #21021. PR Close #40534
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
patchValueof theFormGroupandFormArrayclasses used to throw an exceptionwhen the
valueargument contained a data structure that hasnullorundefinedas a value for a fieldthat represents an instance of
FormGrouporFormArray(forFormControlit's not a problem, since itdoesn't have nested controls), since the
patchValuemethod tried to iterate over provided value tomatch current data structure.
This commit updates the
patchValuelogic inFormGroupandFormArrayclasses to just ignorenullandundefinedvalues (without any changes to correspondingFormGroupandFormArrayinstances). Thisbehavior is inline with the
patchValuemethod goal of "doing its best to match the values to the correct controls"(quote from docs).
Fixes #36672.
Fixes #21021.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?