Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): implement realpath to resolve symlinks #40593

Closed
wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Jan 27, 2021

The LanguageServiceAdapter must implement realpath in order to resolve
symlinks in node_modules.

Local libraries are often symlinked in node_modules by adding a local
dependency in package.json.

Fix angular/vscode-ng-language-service#1083

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau added area: language-service Issues related to Angular's VS Code language service target: patch This PR is targeted for the next patch release labels Jan 27, 2021
@kyliau kyliau requested a review from atscott January 27, 2021 17:20
@ngbot ngbot bot modified the milestone: Backlog Jan 27, 2021
@google-cla google-cla bot added the cla: yes label Jan 27, 2021
The `LanguageServiceAdapter` must implement `realpath` in order to resolve
symlinks in `node_modules`.

Local libraries are often symlinked in `node_modules` by adding a local
dependency in `package.json`.

Fix angular/vscode-ng-language-service#1083
@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Jan 27, 2021
@kyliau kyliau requested a review from atscott January 27, 2021 18:09
jessicajaniuk pushed a commit that referenced this pull request Jan 27, 2021
The `LanguageServiceAdapter` must implement `realpath` in order to resolve
symlinks in `node_modules`.

Local libraries are often symlinked in `node_modules` by adding a local
dependency in `package.json`.

Fix angular/vscode-ng-language-service#1083

PR Close #40593
@kyliau kyliau deleted the realpath branch January 27, 2021 18:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directives and pipes are not recognized from a library
2 participants