fix(forms): the min and max validators should work correctly with 0 as a value
#42412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRealNirmal
force-pushed
the
forms-validator-fix-minmax
branch
3 times, most recently
from
c72296d
to
e0ba47b
Compare
|
@AndrewKushnir PR is ready for hot fix of min and max validator. Let me know if you need me to include anything else in this PR |
14 tasks
AndrewKushnir
added
action: review
AndrewKushnir
requested changes
Jun 2, 2021
There was a problem hiding this comment.
Thanks for the fix @iRealNirmal. I've left a comment regarding tests, please have a look when you get a chance.
I'd also propose to update the commit message to provide a bit more info on the problem (especially the title of the commit message that'd be included into the changelog):
fix(forms): the `min` and `max` validators should work correctly with `0` as a value
Prior to this change the `min` and `max` validator directives would not set the `min` and `max` attributes on the host element. The problem was caused by the truthy check in host binding expression that was calculated as `false` when `0` is used as a value. This commit updates the logic to leverage nullish coalescing operator in these host binding expressions, so `0` is treated as a valid value, thus the `min` and `max` attributes are set correctly.
Partially closes #42267.
e89a65b
to
734e98f
Compare
… `0` as a value Prior to this change the `min` and `max` validator directives would not set the `min` and `max` attributes on the host element. The problem was caused by the truthy check in host binding expression that was calculated as `false` when `0` is used as a value. This commit updates the logic to leverage nullish coalescing operator in these host binding expressions, so `0` is treated as a valid value, thus the `min` and `max` attributes are set correctly. Partially closes angular#42267
iRealNirmal
force-pushed
the
forms-validator-fix-minmax
branch
from
734e98f
to
44e54d1
Compare
iRealNirmal
changed the title
min and max validators should work correctly with 0 as a value
AndrewKushnir
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
Thanks for addressing the feedback @iRealNirmal, the changes look good 👍
I've started tests in Google's codebase and will let you know how it goes.
AndrewKushnir
added
action: presubmit
|
@iRealNirmal FYI tests in Google's codebase went well, I'm adding this PR to the merge queue. Thanks for the fix 👍 |
AndrewKushnir
added
action: merge
jessicajaniuk
pushed a commit
that referenced
this pull request
Jun 3, 2021
… `0` as a value (#42412) Prior to this change the `min` and `max` validator directives would not set the `min` and `max` attributes on the host element. The problem was caused by the truthy check in host binding expression that was calculated as `false` when `0` is used as a value. This commit updates the logic to leverage nullish coalescing operator in these host binding expressions, so `0` is treated as a valid value, thus the `min` and `max` attributes are set correctly. Partially closes #42267 PR Close #42412
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved min and max validator issue as it wasn't working when value was set to 0.
Partially closes #42267
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Min and max validators are not working when it's set to 0.
Issue Number: #42267
What is the new behavior?
min and max validator will work when value is set to 0.
Does this PR introduce a breaking change?
Other information