New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(router): fix serializeQueryParams
logic
#42481
Conversation
ab49a81
to
01141cd
Compare
corrects a bug that resulted in query params such as `[queryParams]={a: 1, b:[]}` being serialized as 'a=1&' instead of 'a=1' resolves angular#42445
01141cd
to
08a6d85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Depending on the presubmit results, we can probably submit this as purely a bug fix (without the breaking change). Will update once those tests have been run.
@atscott FYI, I've started a global presubmit for the changes in this PR. |
Global presubmits show no failures so we should be good to submit this as a non-breaking fix. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
corrects a bug that resulted in query params such as `[queryParams]={a: 1, b:[]}` being serialized as 'a=1&' instead of 'a=1' resolves angular#42445 PR Close angular#42481
I am currently marking this as a breaking change out of an abundance of caution, because it does make a small change to the way query params are serialized into a url. The maintainers can decide if it truly is a breaking change.
corrects a bug that resulted in query params such as
{a: 1, b:[]}
being serialized as 'a=1&' instead of 'a=1'resolves #42445
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
It changes the way query params are serialized into a url
What is the current behavior?
Something like
[queryParams]={a: 1, b:[]}
gets serialized as 'a=1&'Issue Number: #42445
What is the new behavior?
Something like
[queryParams]={a: 1, b:[]}
gets serialized as 'a=1'Does this PR introduce a breaking change?
The url generated by the router link directive will be different if this PR is merged. It will no longer contain the extra ampersand.
Other information