New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(language-service): 'go to defininition' for objects defined in te… #42559
Conversation
ef5c8c0
to
e06da35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything will work, but making a helper function for getFinalDefinitionInfos
doesn't add value IMHO. the structure could be thought-through more and easier to follow.
05faeab
to
68b4141
Compare
…mplate Previously, the "go to definition" action did no account for the possibility that something may actually be defined in a template. This change updates the logic in the definition builder to convert any results that are locations in template typecheck files to their corresponding locations in the template.
68b4141
to
2b7e803
Compare
…mplate (#42559) Previously, the "go to definition" action did no account for the possibility that something may actually be defined in a template. This change updates the logic in the definition builder to convert any results that are locations in template typecheck files to their corresponding locations in the template. PR Close #42559
PR angular#42559 added a reference to a helper method that was only in the 12.1.x branch. This commit adds the helper to the 12.0.x branch.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…mplate
Previously, the "go to definition" action did no account for the
possibility that something may actually be defined in a template. This
change updates the logic in the definition builder to convert any
results that are locations in template typecheck files to their
corresponding locations in the template.