Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): 'go to defininition' for objects defined in te… #42559

Closed
wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Jun 11, 2021

…mplate

Previously, the "go to definition" action did no account for the
possibility that something may actually be defined in a template. This
change updates the logic in the definition builder to convert any
results that are locations in template typecheck files to their
corresponding locations in the template.

@atscott atscott added area: language-service Issues related to Angular's VS Code language service target: patch This PR is targeted for the next patch release labels Jun 11, 2021
@ngbot ngbot bot modified the milestone: Backlog Jun 11, 2021
@google-cla google-cla bot added the cla: yes label Jun 11, 2021
Copy link
Contributor

@zarend zarend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything will work, but making a helper function for getFinalDefinitionInfos doesn't add value IMHO. the structure could be thought-through more and easier to follow.

packages/language-service/ivy/definitions.ts Outdated Show resolved Hide resolved
@atscott atscott force-pushed the lsdefinitionofvarproperty branch 2 times, most recently from 05faeab to 68b4141 Compare June 11, 2021 23:35
…mplate

Previously, the "go to definition" action did no account for the
possibility that something may actually be defined in a template. This
change updates the logic in the definition builder to convert any
results that are locations in template typecheck files to their
corresponding locations in the template.
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Jun 12, 2021
alxhub pushed a commit that referenced this pull request Jun 14, 2021
…mplate (#42559)

Previously, the "go to definition" action did no account for the
possibility that something may actually be defined in a template. This
change updates the logic in the definition builder to convert any
results that are locations in template typecheck files to their
corresponding locations in the template.

PR Close #42559
@alxhub alxhub closed this in 4001e9d Jun 14, 2021
atscott added a commit to atscott/angular that referenced this pull request Jun 15, 2021
PR angular#42559 added a reference to a helper method that was only in the 12.1.x branch.
This commit adds the helper to the 12.0.x branch.
alxhub pushed a commit that referenced this pull request Jun 15, 2021
PR #42559 added a reference to a helper method that was only in the 12.1.x branch.
This commit adds the helper to the 12.0.x branch.

PR Close #42579
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants