fix(zone.js): in TaskTrackingZoneSpec track a periodic task until it is cancelled #45391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platonn
force-pushed
the
fix/45350
branch
2 times, most recently
from
2e36dde
to
6766dd1
Compare
|
Hi @JiaLiPassion. Thanks for reviewing the PR. Can you help me confirm this PR is a "breaking change" for zone.js and/or even Angular packages? This PR changes a behavior of
|
…is cancelled
Before this change, the macrotask for `setInterval(callback, ms)` was no
longer tracked by `TaskTrackingZoneSpec` after the `callback` was
invoked for the first time. Now the periodic macrotask is tracked until
it is cancelled, e.g. `clearInterval(id)`.
BREAKING CHANGE: in TaskTrackingZoneSpec track a periodic task until it is cancelled
The breaking change is scoped only to the plugin
`zone.js/plugins/task-tracking`. If you used `TaskTrackingZoneSpec` and
checked the pending macroTasks e.g. using `(this.ngZone as any)._inner
._parent._properties.TaskTrackingZone.getTasksFor('macroTask')`, then
its behavior slightly changed for periodic macrotasks. For example,
previously the `setInterval` macrotask was no longer tracked after its
callback was executed for the first time. Now it's tracked until
the task is explicitly cancelled, e.g with `clearInterval(id)`.
fixes 45350
JiaLiPassion
added
area: zones
target: minor
JiaLiPassion
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
LGTM!
@AndrewKushnir , could you help me to run a global presubmit to check whether this PR impact the g3? Thank you.
AndrewKushnir
added
the
action: presubmit
|
@JiaLiPassion FYI the global presubmit went well, no broken/failing targets. Please add the "merge" label is there are no additional changes expected in this PR. |
AndrewKushnir
removed
the
action: presubmit
|
@AndrewKushnir , got it, thank you. |
dylhunn
added
target: major
|
This PR was merged into the repository by commit f19b36f. |
PiyushAgrawal1243
pushed a commit
to PiyushAgrawal1243/angular
that referenced
this pull request
Mar 30, 2022
…is cancelled (angular#45391) Before this change, the macrotask for `setInterval(callback, ms)` was no longer tracked by `TaskTrackingZoneSpec` after the `callback` was invoked for the first time. Now the periodic macrotask is tracked until it is cancelled, e.g. `clearInterval(id)`. BREAKING CHANGE: in TaskTrackingZoneSpec track a periodic task until it is cancelled The breaking change is scoped only to the plugin `zone.js/plugins/task-tracking`. If you used `TaskTrackingZoneSpec` and checked the pending macroTasks e.g. using `(this.ngZone as any)._inner ._parent._properties.TaskTrackingZone.getTasksFor('macroTask')`, then its behavior slightly changed for periodic macrotasks. For example, previously the `setInterval` macrotask was no longer tracked after its callback was executed for the first time. Now it's tracked until the task is explicitly cancelled, e.g with `clearInterval(id)`. fixes 45350 PR Close angular#45391
josmar-crwdstffng
pushed a commit
to josmar-crwdstffng/angular
that referenced
this pull request
Apr 8, 2022
…is cancelled (angular#45391) Before this change, the macrotask for `setInterval(callback, ms)` was no longer tracked by `TaskTrackingZoneSpec` after the `callback` was invoked for the first time. Now the periodic macrotask is tracked until it is cancelled, e.g. `clearInterval(id)`. BREAKING CHANGE: in TaskTrackingZoneSpec track a periodic task until it is cancelled The breaking change is scoped only to the plugin `zone.js/plugins/task-tracking`. If you used `TaskTrackingZoneSpec` and checked the pending macroTasks e.g. using `(this.ngZone as any)._inner ._parent._properties.TaskTrackingZone.getTasksFor('macroTask')`, then its behavior slightly changed for periodic macrotasks. For example, previously the `setInterval` macrotask was no longer tracked after its callback was executed for the first time. Now it's tracked until the task is explicitly cancelled, e.g with `clearInterval(id)`. fixes 45350 PR Close angular#45391
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the macrotask for
setInterval(callback, ms)was nolonger tracked by
TaskTrackingZoneSpecafter thecallbackwasinvoked for the first time. Now the periodic macrotask is tracked until
it is cancelled, e.g.
clearInterval(id).PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #45350
Before this change, the macrotask for
setInterval(callback, ms)was nolonger tracked by
TaskTrackingZoneSpecafter thecallbackwasinvoked for the first time.
What is the new behavior?
Now the periodic macrotask is tracked by
TaskTrackingZoneSpecuntilthe task is cancelled, e.g.
clearInterval(id).Does this PR introduce a breaking change?
The breaking change is scoped only to the plugin
zone.js/plugins/task-tracking. If you usedTaskTrackingZoneSpecand checked the pending macroTasks e.g. using(this.ngZone as any)._inner._parent._properties.TaskTrackingZone.getTasksFor('macroTask'), then its behavior slightly changed for periodic macrotasks. For example, previously thesetIntervalmacrotask was no longer tracked after its callback was executed for the first time. Now it's tracked until the task is explicitly cancelled, e.g withclearInterval(id).