-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Git Bash fails running scriptlet ng-dev #46858
Comments
Git for Windows $PWD causes the path to tsconfig.json to be prefixed with the drive letter twice like C:\c\ Fixes angular#46858
As stated in the PR, this is a temporary solution, we are working with ts-node to fix this (the initial fix PR landed there already). |
I'm confused why the path is ending up like this for you. We specifically tested with Git Bash before we applied this temporary trick. |
As this was a "probably" in my assessment above, I added https://www.npmjs.com/package/@bahmutov/print-env , and ran
Running
So something after the |
I ran I'll try all this under Which git bash version are you using? |
We actually should be able to. I have landed a fix on their repository. I don't know if it's released though yet.. |
In the past, `ts-node` had a bug that prevented forking processes when used in combination with `--esm`. We contributed a fix upstream to `ts-node` to fix this, and this commit updates to the latest version so that we can simplify our `ng-dev` invocation. TypeStrong/ts-node@32d07e2 Fixes angular#46858
In the past, `ts-node` had a bug that prevented forking processes when used in combination with `--esm`. We contributed a fix upstream to `ts-node` to fix this, and this commit updates to the latest version so that we can simplify our `ng-dev` invocation. TypeStrong/ts-node@32d07e2 Fixes #46858 PR Close #49289
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Which @angular/* package(s) are the source of the bug?
Don't known / other
Is this a regression?
Yes
Description
63396a1 (less than a month ago) appears to have broken the
ng-dev
command on Git for Windows Bash. Occurs here and thecomponents
repo.If I replace
TS_NODE_PROJECT=$PWD/.ng-dev/tsconfig.json
withTS_NODE_PROJECT=.ng-dev/tsconfig.json
, it works.Presumably
$PWD
is a full path provided by MSYS, but probably using/c/directory/etc
style slashes, and something is rewriting it and adding C:\ in front, becausets-node
is attempting to openC:\c\Projects\ng\angular\.ng-dev\tsconfig.json
Note there is no nodejs in the msys/mingw package collection any more: msys2/MINGW-packages#6237
And https://github.com/kentcdodds/cross-env repo has been archived, so this path handling problem cant be solved there kentcdodds/cross-env#257
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
Please provide the environment you discovered this bug in (run
ng version
)Anything else?
No response
The text was updated successfully, but these errors were encountered: