Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): revert commit that replaced last helper with native `A… #54021

Closed
wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Jan 22, 2024

…rray.at(-1)`

While Array.at is technically supported in all browsers we officially support, the change was needlessly breaking without any real benefit.

…rray.at(-1)`

While `Array.at` is technically supported in all browsers we officially
support, the change was needlessly breaking without any real benefit.
@atscott atscott added area: router target: lts This PR is targeting a version currently in long-term support labels Jan 22, 2024
@ngbot ngbot bot added this to the Backlog milestone Jan 22, 2024
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Jan 22, 2024
@pkozlowski-opensource pkozlowski-opensource added target: patch This PR is targeted for the next patch release and removed target: lts This PR is targeting a version currently in long-term support labels Jan 24, 2024
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit bc85551.

pkozlowski-opensource pushed a commit that referenced this pull request Jan 24, 2024
…rray.at(-1)` (#54021)

While `Array.at` is technically supported in all browsers we officially
support, the change was needlessly breaking without any real benefit.

PR Close #54021
pkozlowski-opensource pushed a commit to pkozlowski-opensource/angular that referenced this pull request Jan 24, 2024
…rray.at(-1)` (angular#54021)

While `Array.at` is technically supported in all browsers we officially
support, the change was needlessly breaking without any real benefit.

PR Close angular#54021
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
…rray.at(-1)` (angular#54021)

While `Array.at` is technically supported in all browsers we officially
support, the change was needlessly breaking without any real benefit.

PR Close angular#54021
danieljancar pushed a commit to danieljancar/angular that referenced this pull request Jan 26, 2024
…rray.at(-1)` (angular#54021)

While `Array.at` is technically supported in all browsers we officially
support, the change was needlessly breaking without any real benefit.

PR Close angular#54021
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
…rray.at(-1)` (angular#54021)

While `Array.at` is technically supported in all browsers we officially
support, the change was needlessly breaking without any real benefit.

PR Close angular#54021
nikvarma pushed a commit to nikvarma/angular that referenced this pull request Jan 31, 2024
…rray.at(-1)` (angular#54021)

While `Array.at` is technically supported in all browsers we officially
support, the change was needlessly breaking without any real benefit.

PR Close angular#54021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: router target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants