fix(compiler): capture data bindings for content projection purposes in blocks #54876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in blocks Fixes a regression in the template pipeline where data bindings weren't being captured for content projection purposes. Fixes angular#54872.
crisbeto
commented
Mar 15, 2024
| @@ -359,7 +359,7 @@ function ingestIfBlock(unit: ViewCompilationUnit, ifBlock: t.IfBlock): void { | |||
| cView.contextVariables.set(ifCase.expressionAlias.name, ir.CTX_REF); | |||
| } | |||
|
|
|||
| let ifCaseI18nMeta = undefined; | |||
| let ifCaseI18nMeta: i18n.BlockPlaceholder|undefined = undefined; | |||
There was a problem hiding this comment.
Unrelated change, I just saw that vscode was flagging this as an error.
| for (const attr of root.attributes) { | ||
| const securityContext = domSchema.securityContext(NG_TEMPLATE_TAG_NAME, attr.name, true); | ||
| unit.update.push(ir.createBindingOp( | ||
| xref, ir.BindingKind.Attribute, attr.name, o.literal(attr.value), null, securityContext, | ||
| true, false, null, asMessage(attr.i18n), attr.sourceSpan)); | ||
| } | ||
|
|
||
| // Also collect the inputs since they participate in content projection as well. |
crisbeto
added
action: review
pkozlowski-opensource
approved these changes
Mar 15, 2024
dylhunn
approved these changes
Mar 15, 2024
|
(thanks for fixing this issue @crisbeto!) |
crisbeto
added
action: merge
|
This PR was merged into the repository by commit 879bd80. |
ilirbeqirii
pushed a commit
to ilirbeqirii/angular
that referenced
this pull request
Apr 6, 2024
…in blocks (angular#54876) Fixes a regression in the template pipeline where data bindings weren't being captured for content projection purposes. Fixes angular#54872. PR Close angular#54876
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression in the template pipeline where data bindings weren't being captured for content projection purposes.
Fixes #54872.