Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Fix clearing of pending task in zoneless cleanup implement… #55074

Closed
wants to merge 1 commit into from
Closed

fix(core): Fix clearing of pending task in zoneless cleanup implement… #55074

wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Mar 27, 2024

…ation

This commit fixes a mistake in #54952 where the first pending task was falsey because its ID is 0

@atscott
fix(core): Fix clearing of pending task in zoneless cleanup implement…
735b21c 
…ation

This commit fixes a mistake in angular#54952 where the first pending task was falsey because its ID is 0
@atscott atscott requested a review from dylhunn March 27, 2024 21:04
@atscott atscott added the area: core Issues related to the framework runtime label Mar 27, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 27, 2024
@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Mar 27, 2024
@dylhunn
Copy link
Contributor

dylhunn commented Mar 27, 2024

This PR was merged into the repository by commit e02bcf8.

@dylhunn dylhunn closed this in e02bcf8 Mar 27, 2024
ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
@atscott @ilirbeqirii
fix(core): Fix clearing of pending task in zoneless cleanup implement…
d73b86e 
…ation (angular#55074)

This commit fixes a mistake in angular#54952 where the first pending task was falsey because its ID is 0

PR Close angular#55074
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dylhunn dylhunn dylhunn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@atscott @dylhunn