fix(core): handle ChainedInjectors in injector debug utils
#55144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix from PR angular#55079 introduced a configuration of the injector chain, which wasn't properly handled by the injector debug utils, thus resulting in JS exceptions in DevTools. This commit updates injector debug utils logic that calculates injector resolution path to also handle `ChainedInjector`s. Resolves angular#55137.
AndrewKushnir
added
action: review
AndrewKushnir
commented
Apr 1, 2024
| @@ -6,33 +6,33 @@ | |||
| * found in the LICENSE file at https://angular.io/license | |||
| */ | |||
|
|
|||
| import {ENVIRONMENT_INITIALIZER} from '../../di/initializer_token'; | |||
There was a problem hiding this comment.
Note for reviewers: there were no changes to the imports, the order has changed as a result of running yarn lint.
2 tasks
garrettld
reviewed
Apr 1, 2024
alxhub
approved these changes
Apr 2, 2024
AndrewKushnir
added
action: merge
|
Caretaker note: the presubmit is "green", this PR is ready for merge. |
|
This PR was merged into the repository by commit 231e0a3. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Apr 3, 2024
The fix from PR #55079 introduced a configuration of the injector chain, which wasn't properly handled by the injector debug utils, thus resulting in JS exceptions in DevTools. This commit updates injector debug utils logic that calculates injector resolution path to also handle `ChainedInjector`s. Resolves #55137. PR Close #55144
ilirbeqirii
pushed a commit
to ilirbeqirii/angular
that referenced
this pull request
Apr 6, 2024
…#55144) The fix from PR angular#55079 introduced a configuration of the injector chain, which wasn't properly handled by the injector debug utils, thus resulting in JS exceptions in DevTools. This commit updates injector debug utils logic that calculates injector resolution path to also handle `ChainedInjector`s. Resolves angular#55137. PR Close angular#55144
This was referenced Apr 26, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix from PR #55079 introduced a configuration of the injector chain, which wasn't properly handled by the injector debug utils, thus resulting in JS exceptions in DevTools. This commit updates injector debug utils logic that calculates injector resolution path to also handle
ChainedInjectors.Resolves #55137.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?