Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update v0 render to v17 #55368

Closed
wants to merge 1 commit into from
Closed

docs: update v0 render to v17 #55368

wants to merge 1 commit into from

Conversation

bencodezen
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #55303

What is the new behavior?

Instead of auto-detecting the version since we have som package discrepancies, this will hardcode it for now so people are not confused by the version selector.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot bot added the area: docs Related to the documentation label Apr 16, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 16, 2024
@bencodezen bencodezen added action: review The PR is still awaiting reviews from at least one requested reviewer area: adev Angular.dev documentation labels Apr 16, 2024
@bencodezen bencodezen linked an issue Apr 16, 2024 that may be closed by this pull request
Angular.dev show v0 instead of the latest version v17 #55303
Open
JeanMeche
JeanMeche approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go !

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Apr 16, 2024
@pkozlowski-opensource pkozlowski-opensource removed the request for review from twerske April 17, 2024 06:00
@pkozlowski-opensource pkozlowski-opensource removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 17, 2024
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit c778977.

iteriani pushed a commit to iteriani/angular that referenced this pull request Apr 18, 2024
@bencodezen @iteriani
docs: update v0 render to v17 (angular#55368)
61bebd8 
PR Close angular#55368
@mgechev mgechev deleted the 55303-fix-v0-version-number branch April 25, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: adev Angular.dev documentation area: docs Related to the documentation target: major This PR is targeted for the next major release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Angular.dev show v0 instead of the latest version v17
3 participants
@bencodezen @pkozlowski-opensource @JeanMeche