fix(router): Allow renavigating to failed URLs #43424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
action: review
AndrewKushnir
approved these changes
Sep 10, 2021
atscott
force-pushed
the
routerRecover
branch
from
8fd782b
to
7f0721d
Compare
There are situations where the Router does not currently clean up failed navigations correctly. While this is problematic on its own, we can mitigate some of the damage by processing any URL when we get a navigation request when the internal router state is out of sync. Each of the added tests would fail without this change. fixes angular#34795
atscott
force-pushed
the
routerRecover
branch
from
7f0721d
to
e3f87d8
Compare
atscott
added
action: merge
AndrewKushnir
pushed a commit
that referenced
this pull request
Sep 13, 2021
There are situations where the Router does not currently clean up failed navigations correctly. While this is problematic on its own, we can mitigate some of the damage by processing any URL when we get a navigation request when the internal router state is out of sync. Each of the added tests would fail without this change. fixes #34795 PR Close #43424
TeriGlover
pushed a commit
to TeriGlover/angular
that referenced
this pull request
Sep 16, 2021
There are situations where the Router does not currently clean up failed navigations correctly. While this is problematic on its own, we can mitigate some of the damage by processing any URL when we get a navigation request when the internal router state is out of sync. Each of the added tests would fail without this change. fixes angular#34795 PR Close angular#43424
TeriGlover
pushed a commit
to TeriGlover/angular
that referenced
this pull request
Sep 22, 2021
There are situations where the Router does not currently clean up failed navigations correctly. While this is problematic on its own, we can mitigate some of the damage by processing any URL when we get a navigation request when the internal router state is out of sync. Each of the added tests would fail without this change. fixes angular#34795 PR Close angular#43424
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are situations where the Router does not currently clean up failed navigations
correctly. While this is problematic on its own, we can mitigate some of
the damage by processing any URL when we get a navigation request when
the internal router state is out of sync.
Each of the added tests would fail without this change.
fixes #34795
Green TGP