Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(language-service): support to fix invalid banana in box #47393

Closed
wants to merge 1 commit into from
Closed

feat(language-service): support to fix invalid banana in box #47393

wants to merge 1 commit into from

Conversation

ivanwonder
Copy link
Contributor

@ivanwonder ivanwonder commented Sep 9, 2022 •
edited

The Angular compiler will report the invalid banana in box, this code fixes will try to fix the error and all the same errors in the selected file.

fixes #44941

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ivanwonder ivanwonder force-pushed the fix-invalid-banana-in-box branch 3 times, most recently from 07cc6a0 to c3e4bfa Compare September 9, 2022 12:55
@ivanwonder ivanwonder marked this pull request as ready for review September 9, 2022 13:24
@pullapprove pullapprove bot requested a review from alxhub September 9, 2022 13:24
@ivanwonder
Copy link
Contributor Author

@dylhunn

@ivanwonder ivanwonder mentioned this pull request Sep 9, 2022
Closed
@jessicajaniuk jessicajaniuk added the area: language-service Issues related to Angular's VS Code language service label Sep 9, 2022
@ngbot ngbot bot added this to the Backlog milestone Sep 9, 2022
@dylhunn dylhunn self-requested a review September 22, 2022 02:35
@dylhunn
Copy link
Contributor

dylhunn commented Sep 22, 2022

Sorry, didn't see this. I'll review tomorrow morning.

@ivanwonder
Copy link
Contributor Author

// cc @atscott

atscott
atscott approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 Awesome. LGTM

Can you also add the "fixes #44941" note to the commit message?

packages/language-service/src/codefixes/fix_invalid_banana_in_box.ts Outdated Show resolved Hide resolved
packages/language-service/src/codefixes/fix_invalid_banana_in_box.ts Outdated Show resolved Hide resolved
packages/language-service/src/codefixes/fix_invalid_banana_in_box.ts Show resolved Hide resolved
packages/language-service/src/codefixes/fix_invalid_banana_in_box.ts Show resolved Hide resolved
dylhunn
dylhunn approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@dylhunn dylhunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: language-service

@dylhunn
Copy link
Contributor

dylhunn commented Sep 23, 2022

Looks like Andrew beat me to it. Thanks for implementing this :)

@ivanwonder ivanwonder force-pushed the fix-invalid-banana-in-box branch 2 times, most recently from 7c30df6 to f47df65 Compare September 23, 2022 12:44
@ivanwonder ivanwonder requested review from atscott and dylhunn and removed request for alxhub, atscott and dylhunn September 23, 2022 12:46
@ivanwonder
feat(language-service): support to fix invalid banana in box
e89c609 
The Angular compiler will report the invalid banana in box, this code fixes
will try to fix the error and all the same errors in the selected file.

Fixes angular#44941
@atscott atscott added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Sep 26, 2022
@alxhub
Copy link
Member

alxhub commented Sep 27, 2022

This PR was merged into the repository by commit e7ee53c.

@alxhub alxhub closed this in e7ee53c Sep 27, 2022
@ivanwonder ivanwonder deleted the fix-invalid-banana-in-box branch September 30, 2022 08:43
@DerZyklop DerZyklop mentioned this pull request Oct 13, 2022
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott atscott approved these changes

@dylhunn dylhunn dylhunn approved these changes

@Jeriko100 Jeriko100 Jeriko100 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Extended diagnostics quick fix
6 participants
@ivanwonder @dylhunn @alxhub @atscott @Jeriko100 @jessicajaniuk