fix(core): update isDevMode to rely on ngDevMode

[alan-agius4]

This commits update isDevMode to rely on the ngDevMode which in the CLI is set by the bundler.

We also update @angular/platform-dynamic-browser and @angular/compiler to remove usage of jitDevMode, which was the last internal usages of isDevMode.

[pkozlowski-opensource]

We've discussed this on the fwk side in the past and I believe that this would be breaking change. Adding a label accordingly.

[alan-agius4]

@pkozlowski-opensource why would this be a breaking change?

Calling enableProdMode sets ngDevMode to false. So, what causes the breaking behaviour? The framework doesn't use the isDevMode method.

[pkozlowski-opensource]

The framework doesn't use the isDevMode method.

@alan-agius4 the framework does not, but the existing libraries might (and probably do).

[AndrewKushnir]

LGTM 👍

It'd be great to add some additional docs for the isDevMode and enableProdMode functions to explain where the value is coming from and what'd be the best way to change it (via CLI flags vs enabling at runtime).

[alxhub]

This PR was merged into the repository by commit 85330f3.

[Platonn]

Hi @alan-agius4. I have a question, so to better understand:
Now isDevMode() explicitly depends on ngDevMode. Does it by any chance help to tree-shake code in custom applications, that is conditionally wrapped with isDevMode()? e.g.

if(isDevMode()){ 
   console.error('Some very long string message in custom app....');
}

If not, would it help to expose ngDevMode in Angular public API, so it could be used it in custom applications?

if(ngDevMode){ 
   console.error('Some very long string message in custom app....');
}

[eneajaho]

Just tested this isDevMode(). It doesn't help tree-shake code.

[alan-agius4]

Indeed this does not aid tree-shaking.

ngDevMode is still considered as a private API, but we do have a project to make this available as a public API.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}