fix(core): correctly check for typeof of undefined in ngDevMode check
#47480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heck Previously, this check was wrong as typeof returns a string.
alan-agius4
added
action: review
| @@ -49,7 +49,7 @@ export function enableProdMode(): void { | |||
|
|
|||
| // The below check is there so when ngDevMode is set via terser | |||
| // `global['ngDevMode'] = false;` is also dropped. | |||
| if (typeof ngDevMode === undefined || !!ngDevMode) { | |||
| if (typeof ngDevMode === 'undefined' || ngDevMode) { | |||
There was a problem hiding this comment.
ha ha - indeed!
can you think of a test that would expose this situation so we don't regress in the future?
There was a problem hiding this comment.
Calling enableProdMode leaks to other tests. Because at the moment we cannot reset _devMode after the enableProdMode test.
As such, probably I will have to remove the test.
pkozlowski-opensource
added
the
area: core
alan-agius4
force-pushed
the
type-of-string
branch
from
dfe887b
to
85a8210
Compare
alan-agius4
force-pushed
the
type-of-string
branch
from
b71b754
to
85a8210
Compare
pkozlowski-opensource
approved these changes
Sep 20, 2022
alan-agius4
added
action: merge
|
This PR was merged into the repository by commit aef8d0b. |
sonukapoor
pushed a commit
to sonukapoor/angular
that referenced
this pull request
Sep 27, 2022
…heck (angular#47480) Previously, this check was wrong as typeof returns a string. PR Close angular#47480
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Oct 5, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.2.3` -> `14.2.4`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.2.3/14.2.4) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.2.3` -> `14.2.4`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.2.3/14.2.4) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.2.3` -> `14.2.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.2.3/14.2.4) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`14.2.3` -> `14.2.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.2.3/14.2.4) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.2.3` -> `14.2.4`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.2.3/14.2.4) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.2.3` -> `14.2.4`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.2.3/14.2.4) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.2.3` -> `14.2.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.2.3/14.2.4) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.2.3` -> `14.2.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.2.3/14.2.4) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v14.2.4`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1424-2022-09-28) [Compare Source](angular/angular@14.2.3...14.2.4) ##### compiler-cli | Commit | Type | Description | | -- | -- | -- | | [a4b66fe1e5](angular/angular@a4b66fe) | perf | cache source file for reporting type-checking diagnostics ([#​47508](angular/angular#47508)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [2c46b5ab24](angular/angular@2c46b5a) | fix | correctly check for `typeof` of undefined in `ngDevMode` check ([#​47480](angular/angular#47480)) | #### Special Thanks Alan Agius, Ashley Hunter, Doug Parker, Jessica Janiuk, JoostK, Kristiyan Kostadinov, Rokas Brazdžionis and Simona Cotin <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMCIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4wIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1569 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this check was wrong as typeof returns a string.