-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control flow migration fails for async pipe with unboxing of observable. #52756
Labels
area: migrations
Issues related to `ng update` migrations
core: control flow
Issues related to the built-in control flow (@if, @for, @switch)
Milestone
Comments
sfabriece
changed the title
Control flow migration failes for async pipe with unboxing of observable.
Control flow migration fails for async pipe with unboxing of observable.
Nov 9, 2023
pkozlowski-opensource
added
area: migrations
Issues related to `ng update` migrations
core: control flow
Issues related to the built-in control flow (@if, @for, @switch)
labels
Nov 9, 2023
Hi, |
The issue is that the migration should be producing |
Ok 👍 I think I got the fix |
AnthonyFr75
added a commit
to AnthonyFr75/forkedAngular
that referenced
this issue
Nov 20, 2023
…oxing of observable Update control flow syntax to use 'as' for proper async pipe handling, accounting for variable whitespace before 'let'. Fixes angular#52756
AnthonyFr75
added a commit
to AnthonyFr75/forkedAngular
that referenced
this issue
Nov 20, 2023
…oxing of observable (angular#52756) Update control flow syntax to use 'as' for proper async pipe handling, accounting for variable whitespace before 'let'. Fixes angular#52756
AndrewKushnir
pushed a commit
that referenced
this issue
Nov 20, 2023
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this issue
Dec 6, 2023
…oxing of observable (angular#52756) (angular#52972) Update control flow syntax to use 'as' for proper async pipe handling, accounting for variable whitespace before 'let'. Fixes angular#52756 PR Close angular#52972
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this issue
Jan 23, 2024
…oxing of observable (angular#52756) (angular#52972) Update control flow syntax to use 'as' for proper async pipe handling, accounting for variable whitespace before 'let'. Fixes angular#52756 PR Close angular#52972
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this issue
Jan 26, 2024
…oxing of observable (angular#52756) (angular#52972) Update control flow syntax to use 'as' for proper async pipe handling, accounting for variable whitespace before 'let'. Fixes angular#52756 PR Close angular#52972
amilamen
pushed a commit
to amilamen/angular
that referenced
this issue
Jan 26, 2024
…oxing of observable (angular#52756) (angular#52972) Update control flow syntax to use 'as' for proper async pipe handling, accounting for variable whitespace before 'let'. Fixes angular#52756 PR Close angular#52972
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: migrations
Issues related to `ng update` migrations
core: control flow
Issues related to the built-in control flow (@if, @for, @switch)
Which @angular/* package(s) are the source of the bug?
core
Is this a regression?
Yes
Description
I run the control flow migration on my code and it failed compilation.
before:
<ng-container *ngIf="value$ | async; let value">
{{value}}
after:
@if (value$ | async; let value) {
{{value}}
}
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
Please provide the environment you discovered this bug in (run
ng version
)Anything else?
No response
The text was updated successfully, but these errors were encountered: